Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Che Theia CSS styling to respect the VS Code theming approach #16079

Closed
azatsarynnyy opened this issue Feb 19, 2020 · 0 comments · Fixed by eclipse-che/che-theia#656
Closed

Update Che Theia CSS styling to respect the VS Code theming approach #16079

azatsarynnyy opened this issue Feb 19, 2020 · 0 comments · Fixed by eclipse-che/che-theia#656
Assignees
@azatsarynnyy
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Milestone
7.10

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Feb 19, 2020 •
edited
Loading

Is your task related to a problem? Please describe.

VS Code like theming has been introduced Theia upstream.
Che Theia styles have to be updated to respect the new theming approach. It will allow us to consume VS Code extensions that provide themes.

Describe the solution you'd like

Update the variables in the CSS styles.

Describe alternatives you've considered

Additional context

Theia PR for VS Code theming support eclipse-theia/theia#6475
Theming guidelines in Theia https://github.com/eclipse-theia/theia/wiki/Coding-Guidelines#theming
VS Code colors https://code.visualstudio.com/api/references/theme-color
@azatsarynnyy azatsarynnyy added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che labels Feb 19, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Feb 19, 2020
Closed
16 tasks
@azatsarynnyy azatsarynnyy self-assigned this Mar 5, 2020
@azatsarynnyy azatsarynnyy added the status/in-progress This issue has been taken by an engineer and is under active development. label Mar 5, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Mar 5, 2020
Merged
@azatsarynnyy azatsarynnyy added this to the 7.10.0 milestone Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatsarynnyy azatsarynnyy

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Milestone
7.10
Development

Successfully merging a pull request may close this issue.

Update Che Theia CSS styling to respect the VS Code theming approach eclipse-che/che-theia
1 participant
@azatsarynnyy