Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if an OAuth identity provider exist instead of looking for OpenShift users #16837

Closed
l0rd opened this issue May 4, 2020 · 3 comments
Closed

Check if an OAuth identity provider exist instead of looking for OpenShift users #16837

l0rd opened this issue May 4, 2020 · 3 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.13

Comments

@l0rd
Copy link
Contributor

l0rd commented May 4, 2020

Is your enhancement related to a problem? Please describe.

Che deployment on OpenShift using OpenShift OAuth fails if users have not logged in OpenShift yet.

Describe the solution you'd like

To figure out if at least one user exist we check for valid OpenShift users. We should check for valid identity providers instead.
@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. team/devex labels May 4, 2020
@l0rd l0rd mentioned this issue May 4, 2020
Closed
3 tasks
@l0rd l0rd added the area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator label May 5, 2020
@tolusha tolusha added this to the Backlog - Deploy milestone May 6, 2020
@davidfestal davidfestal mentioned this issue May 6, 2020
Closed
@tolusha tolusha mentioned this issue May 8, 2020
Closed
56 tasks
@AndrienkoAleksandr
Copy link
Contributor

Done eclipse-che/che-operator#248

@tolusha tolusha modified the milestones: Backlog - Deploy, 7.13 May 15, 2020
@l0rd
Copy link
Contributor Author

l0rd commented May 18, 2020

@tolusha @AndrienkoAleksandr we want to make a CRW 2.1.2 release that includes this fix. How hard is it to cherry pick the fixes for this and #16836 to branch 7.9.x?

@tolusha
Copy link
Contributor

tolusha commented May 18, 2020

@l0rd
We will try

@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue May 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.13
Development

No branches or pull requests
3 participants
@l0rd @tolusha @AndrienkoAleksandr