Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework che-workspace-operator YAMLs so that we don't have seperate k8s/openshift deployment yamls #17010

Closed
JPinkney opened this issue May 25, 2020 · 2 comments
Closed

Rework che-workspace-operator YAMLs so that we don't have seperate k8s/openshift deployment yamls #17010

JPinkney opened this issue May 25, 2020 · 2 comments
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@JPinkney
Copy link
Contributor

Is your task related to a problem? Please describe.

Currently in the che-workspace-operator deployment yamls are separated into k8s/openshift specific folders because cert generation for openshift is done automatically in the operator but k8s cert generation is not (you have to run cert generation manually then patch the deployment). This makes generating the csv's a bit painful as operator-sdk generate csv will pick up the k8s deployment, os deployment, and the registry deployment.

Describe the solution you'd like

Find a way to make it so that we have one deployment file for k8s and openshift

Describe alternatives you've considered

Leave it as is and just do workarounds inside of our Makefile

Additional context
@JPinkney JPinkney added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels May 25, 2020
@amisevsk
Copy link
Contributor

We could potentially use kustomize, or use a sparse checkout in web-terminal-operator

@sleshchenko
Copy link
Member

I think it should be fixed by #17855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sleshchenko @JPinkney @amisevsk