Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chectl] server:update should clearly notify users if images are hard-coded in CheCluster CR #17171

Closed
sleshchenko opened this issue Jun 17, 2020 · 3 comments
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@sleshchenko
Copy link
Member

Is your enhancement related to a problem? Please describe.

Currently, chectl provide a message:

Found deployed Eclipse Che with operator [quay.io/eclipse/che-operator]:7.12.1.
You are going to update it to [quay.io/eclipse/che-operator]:7.12.1.
Note that Eclipse Che operator will update component images (server, plugin registry) only if their values
are not overridden in eclipse-che Custom Resource. So, you may need to remove them manually.
Press q to quit or any key to continue: 

that gives a hint for user that some components may need manual updating after command is executed.
It would be better from UX perspective if chectl check CR and clearly say like:

Found deployed Eclipse Che with operator [quay.io/eclipse/che-operator]:7.12.1.
You are going to update it to [quay.io/eclipse/che-operator]:7.12.1.
[!Manual action required] Che Cluster has the following specified images that should be updated manually or set to '' to let Che Operator manage their values:
cheImage: quay.io/eclipse/che-server:7.12.1
postgresImage: quay.io/eclipse/che-postgres:7.12.1
Press q to quit or any key to continue: 
``
It would allow avoiding confusing and question like this https://github.com/eclipse/che/issues/17110
@sleshchenko sleshchenko added kind/enhancement A feature request - must adhere to the feature request template. area/chectl Issues related to chectl, the CLI of Che labels Jun 17, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jun 17, 2020
@sleshchenko sleshchenko added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jun 17, 2020
@tolusha
Copy link
Contributor

tolusha commented Jul 8, 2020

Closed in favor of #17312

@sleshchenko
Copy link
Member Author

@tolusha seems it's not closed even after your comment but I don't really agree that these issues are about the same issue.
But for sure they can be solved together.

@tolusha
Copy link
Contributor

tolusha commented Sep 7, 2020

Fixed by che-incubator/chectl#827

@tolusha tolusha closed this as completed Sep 7, 2020
@tolusha tolusha added this to the 7.19 milestone Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants