Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor operator to pass deploy.Context into functions instead of numerous arguments #17589

Closed
tolusha opened this issue Aug 6, 2020 · 0 comments
Closed

Refactor operator to pass deploy.Context into functions instead of numerous arguments #17589

tolusha opened this issue Aug 6, 2020 · 0 comments
Assignees
@flacatus
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. kind/technical-debt Technical debt issue severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.19

Comments

@tolusha
Copy link
Contributor

tolusha commented Aug 6, 2020 •
edited
Loading

Is your task related to a problem? Please describe.

Right now in many functions we pass.

  • *orgv1.CheCluster
  • *deploy.ClusterAPI
  • *deploy.Proxy

Describe the solution you'd like

  • Extend the current deploy.Context by adding the structures above.
  • Use deploy.Context as argument to pass into functions

Describe alternatives you've considered

N/A

Additional context

[1] https://github.com/eclipse/che-operator/blob/master/pkg/deploy/data_types.go
@tolusha tolusha added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/technical-debt Technical debt issue labels Aug 6, 2020
@tolusha tolusha added this to the Backlog - Deploy milestone Aug 7, 2020
@tolusha tolusha mentioned this issue Aug 19, 2020
Closed
58 tasks
@flacatus flacatus self-assigned this Aug 21, 2020
@tolusha tolusha modified the milestones: Backlog - Deploy, 7.19 Aug 26, 2020
@flacatus flacatus mentioned this issue Aug 27, 2020
Merged
@tolusha tolusha closed this as completed Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flacatus flacatus

Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. kind/technical-debt Technical debt issue severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.19
Development

No branches or pull requests
2 participants
@tolusha @flacatus