Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the GitHub oAuth is available when asking to sign in the Pull Requests plugin #18237

Closed
vinokurig opened this issue Oct 29, 2020 · 3 comments · Fixed by eclipse-che/che-theia#969
Closed

Check if the GitHub oAuth is available when asking to sign in the Pull Requests plugin #18237

vinokurig opened this issue Oct 29, 2020 · 3 comments · Fixed by eclipse-che/che-theia#969
Assignees
@vinokurig
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.26

Comments

@vinokurig
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

If GitHub identity provider is not setup or GitHub oAuth is not configured, GitHub sign in functionality for the vscode GitHub Pull Request plugin won't work.

Describe the solution you'd like

Check if GitHub oAuth is available. If not, do not show the notification to sign in the GitHub plugin:
screenshot-che-che 192 168 99 254 nip io-2020 10 28-11_30_41

Describe alternatives you've considered

Additional context
@vinokurig vinokurig added kind/enhancement A feature request - must adhere to the feature request template. team/plugins area/plugins labels Oct 29, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 29, 2020
@benoitf
Copy link
Contributor

benoitf commented Oct 29, 2020 •
edited
Loading

Hello, we discussed at the devex call and we wanted to do the following:

two steps like short term and mid-long/term:

  • : Short term: if the github identity provider is not setup, we should notify the user on how to configure it by referencing the documentation (if one project is coming from github)
  • : Mid term: Add a redirect to keycloak URL and how to do the setup (documentation)

@amisevsk amisevsk added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 30, 2020
@sunix sunix mentioned this issue Dec 4, 2020
Closed
1 task
@ericwill ericwill mentioned this issue Dec 4, 2020
Closed
34 tasks
@vinokurig vinokurig self-assigned this Jan 12, 2021
@vinokurig
Copy link
Contributor Author

Is blocked by #18791

@vinokurig vinokurig added the status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. label Jan 13, 2021
@vinokurig vinokurig mentioned this issue Jan 13, 2021
Merged
6 tasks
@ericwill ericwill removed the status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. label Jan 20, 2021
@ericwill ericwill added this to the 7.27 milestone Jan 20, 2021
@ericwill
Copy link
Contributor

Removing blocked status as the dependent issue has been resolved.

@vinokurig vinokurig mentioned this issue Jan 22, 2021
Merged
9 tasks
@ericwill ericwill modified the milestones: 7.27, 7.26 Feb 3, 2021
@ericwill ericwill mentioned this issue Feb 3, 2021
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.26
Development

Successfully merging a pull request may close this issue.

Add docs notification if GitHub oAuth is not setup eclipse-che/che-theia
5 participants
@benoitf @ericwill @vinokurig @amisevsk @che-bot