parameter devfileRegistryPullPolicy is not handled

[benoitf]

Describe the bug

Experimenting happy path on devfile registry, I tried to change the devfile registry policy to IfNotPresent instead of default Always but it was always resulting in error:

12:53:34] ✅  Post installation checklist [failed]
[12:53:34] → Failed to download image, reason: ImagePullBackOff, message: Back-off pulling image "che-devfile-registry-image:latest".
 ›   Error: Error: Failed to download image, reason: ImagePullBackOff, message:
 ›    Back-off pulling image "che-devfile-registry-image:latest".

Che version

• latest
• nightly
• other: please specify

Steps to reproduce

Use a custom resource specServer and use devfileRegistryPullPolicy = 'IfNotPresent'

We see that is related to a probably copy/paste error https://github.com/eclipse/che-operator/blob/482155b7e23a767e2906f0734727a9d23bd65256/pkg/deploy/devfile-registry/deployment.go#L24
as it's referencing PluginRegistryPullPolicy instead of DevfileRegistryPullPolicy

Expected behavior

Policy being handle as specified

Runtime

• kubernetes (include output of kubectl version)
• Openshift (include output of oc version)
• minikube (include output of minikube version and kubectl version)
• minishift (include output of minishift version and oc version)
• docker-desktop + K8S (include output of docker version and kubectl version)
• other: (please specify)

Screenshots

Installation method

• chectl
  • provide a full command that was used to deploy Eclipse Che (including the output)
  • provide an output of chectl version command
• OperatorHub
• I don't know

Environment

• my computer
  • Windows
  • Linux
  • macOS
• Cloud
  • Amazon
  • Azure
  • GCE
  • other (please specify)
• other: please specify

Eclipse Che Logs

Additional context

https://github.com/eclipse/che-operator/blob/482155b7e23a767e2906f0734727a9d23bd65256/pkg/deploy/devfile-registry/deployment.go#L24