Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support single host routing for DevWorkspace engine #18877

Closed
2 tasks done
l0rd opened this issue Jan 25, 2021 · 1 comment
Closed
2 tasks done

Support single host routing for DevWorkspace engine #18877

l0rd opened this issue Jan 25, 2021 · 1 comment
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.

Comments

@l0rd
Copy link
Contributor

l0rd commented Jan 25, 2021

Is your enhancement related to a problem? Please describe.

Che configured to use the DevWorkspace as the workspace engine should use single host strategy. That means that workspaces editors/plugins get routed through the URL path (rather then the subdomain) and devfile components have their own URL sub-domain.

Describe the solution you'd like

  • Support single host deployment in DevWorkspaces platform team
  • validate that when deploying with engine set to devworkspace then it's possible start workspaces both based on devfile v1 and v2 (having both configured as single-host may be tricky and is not in the scope) platform team - deployment of devfile1 through che server and of devfile2 manually using kubectl works, factory links not tested due to lack of support on dashboard side

Subtask "che operator should deploy che-devworkspace-operator (along with devworkspace-operator) when instructed to do so" (#19142) is tracked in a distinct epic #19121.

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Jan 25, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 25, 2021
@l0rd l0rd added this to the DevWorkspace Integration - STEP1 milestone Jan 25, 2021
@l0rd l0rd added engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 25, 2021
@l0rd
Copy link
Contributor Author

l0rd commented Mar 3, 2021

The subtask "che operator should deploy che-devworkspace-operator) is already tracked in the operator epic #19121. I am removing it as a subtask here and closing this epic as it looks like it was the only remaining task. Feel free to re-open if I am getting this wrong.

@l0rd l0rd closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.
Projects
None yet
Development

No branches or pull requests

2 participants