Installation fails when checluster k8s.tlsSecretName is empty

[l0rd]

Describe the bug

Che operator fails to start the Che server if the tlsSecretName is not set or empty.

  "k8s": {
    "tlsSecretName": ""
  }

Che version

nightly

Steps to reproduce

printf "spec:\n  k8s:\n    tlsSecretName: ''\n" > ./checluster-patch.yaml
chectl server:deploy \
      -p minikube --che-operator-cr-patch-yaml=./checluster-patch.yaml

Expected behavior

From the documentation:

If the value is empty or omitted, the default ingress controller certificate will be used.

The relative PR eclipse-che/che-operator#508

Runtime

minikube

minikube version: v1.17.1
commit: 043bdca07e54ab6e4fc0457e3064048f34133d7e
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-14T05:14:17Z", GoVersion:"go1.15.6", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:20:00Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}

Screenshots

Environment

macOS

Eclipse Che Logs

Operator logs:

...
time="2021-02-12T10:09:37Z" level=info msg="Custom resource eclipse-che updated"
time="2021-02-12T10:09:37Z" level=info msg="Waiting on config map 'che' to be created"
time="2021-02-12T10:09:37Z" level=error msg=" secret not found"

Additional context

That looks like a regression of #18079