Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of inversify inside devworkspace-client #19149

Closed
benoitf opened this issue Feb 25, 2021 · 1 comment
Closed

Usage of inversify inside devworkspace-client #19149

benoitf opened this issue Feb 25, 2021 · 1 comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone
7.29

Comments

@benoitf
Copy link
Contributor

benoitf commented Feb 25, 2021

Is your enhancement related to a problem? Please describe.

Che-theia is using inversify so it might be good to use dependency injection in this library to easily mock objects / work with interfaces instead of having static methods

Describe the solution you'd like

Provides inversify modules

Describe alternatives you've considered

N/A

Additional context

N/A
@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. area/dev-workspace-client labels Feb 25, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 25, 2021
@Katka92 Katka92 added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 1, 2021
@sleshchenko sleshchenko mentioned this issue Mar 10, 2021
Closed
31 tasks
@sleshchenko sleshchenko mentioned this issue Mar 25, 2021
Closed
30 tasks
@sleshchenko sleshchenko added this to the 7.29 milestone Mar 25, 2021
@JPinkney JPinkney mentioned this issue Mar 26, 2021
Merged
@JPinkney
Copy link
Contributor

Done in che-incubator/devworkspace-client#15. We've just done it on the node side because we will eventually be removing the browser side anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Milestone
7.29
Development

No branches or pull requests
5 participants
@benoitf @sleshchenko @JPinkney @Katka92 @che-bot