Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Improve verification steps for defining workspace deployment labels&annotations article #19427

Closed
themr0c opened this issue Mar 26, 2021 · 7 comments
Labels
area/doc Issues related to documentation good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@themr0c themr0c added the kind/bug Outline of a bug - must adhere to the bug report template. label Mar 26, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 26, 2021
@themr0c themr0c added area/dashboard severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 26, 2021
@sleshchenko
Copy link
Member

I just tried it on the same Che cluster, which @themr0c used and it works for me. Probably there is some confusion point.
Screenshot_20210326_165928

@themr0c
Copy link
Contributor Author

themr0c commented Mar 29, 2021

Wait ... That's where the confusion is: I should have looked at the deployment label and not at the devfile.

We should probably be more specific in the documentation: add verification steps:

"In the OpenShift console @@ do this to display the deployment labels @@"

@themr0c themr0c added area/doc Issues related to documentation kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. team/doc good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! and removed kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. area/dashboard labels Mar 29, 2021
@MichalMaler
Copy link
Contributor

Related doc issue https://issues.redhat.com/browse/RHDEVDOCS-2884

@MichalMaler
Copy link
Contributor

MichalMaler commented Mar 30, 2021

Working on in in eclipse-che/che-docs#1937

@sleshchenko sleshchenko changed the title define workspace deployment labels and annotations doesn't work on dashboard next Improve verification steps for defining workspace deployment labels&annotations docs article Apr 2, 2021
@sleshchenko sleshchenko changed the title Improve verification steps for defining workspace deployment labels&annotations docs article [doc] Improve verification steps for defining workspace deployment labels&annotations article Apr 2, 2021
@fcomte
Copy link

fcomte commented Aug 19, 2021

I am unable to make this functionnality on my che server.

Version
7.34.0
Browser Name
chrome
Browser Version
84.0.4147
Browser OS
Windows 10

Trying to launch this url :

https://che-host/f?url=https://github.com/maxandersen/quarkus-quickstarts/tree/che&workspaceDeploymentLabels=ike.target%3Dpreference-v1%2Cike.session%3Dtest

give this

apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: "1"
  creationTimestamp: "2021-08-19T12:13:04Z"
  generation: 1
  labels:
    che.component.name: maven
    che.original_name: maven
    che.workspace_id: workspace2tcai8b5i7xth0x3

Is there any prerequisites on the eclipse che server configuration ?

@che-bot
Copy link
Contributor

che-bot commented Feb 15, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2022
@che-bot che-bot closed this as completed Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc Issues related to documentation good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants