Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate manifests and API clients to use the networking.k8s.io/v1 API version #20019

Closed
3 tasks done
flacatus opened this issue Jun 23, 2021 · 9 comments
Closed
3 tasks done
Labels
area/install Issues related to installation, including offline/air gap and initial setup kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@flacatus
Copy link
Contributor

flacatus commented Jun 23, 2021

Is your task related to a problem? Please describe.

The extensions/v1beta1 and networking.k8s.io/v1beta1 API versions of Ingress will no longer be served in v1.22.

Currently extensions/v1beta1 is used:

  1. che-operator: https://github.com/eclipse-che/che-operator/blob/main/pkg/deploy/ingress.go#L64
  2. helmcharts: https://github.com/eclipse-che/che-server/blob/main/deploy/kubernetes/helm/che/templates/ingress.yaml#L23
  3. che-server: fabric8 client which creates Ingress v1beta1

https://github.com/eclipse-che/che-server/blob/main/pom.xml#L75
https://github.com/eclipse-che/che-server/blob/main/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/util/Ingresses.java#L18

Describe the solution you'd like

Migrate manifests and API clients to use the networking.k8s.io/v1 API version, available since v1.19. [1]

Describe alternatives you've considered

N/A

Additional context

N/A

[1] https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122
[2] https://kubernetes.io/releases/

Sub tasks

@flacatus flacatus added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jun 23, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jun 23, 2021
@AndrienkoAleksandr AndrienkoAleksandr added team/deploy severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jun 23, 2021
@tolusha tolusha added area/install Issues related to installation, including offline/air gap and initial setup sprint/next team/deploy and removed team/deploy labels Jun 23, 2021
@l0rd
Copy link
Contributor

l0rd commented Jul 6, 2021

@tolusha @flacatus if we use v1 we won't be able to support older version of Kubernetes and OpenShift right? Maybe that should be reviewed to make sure that we don't break installations on older version that we currently support.

@tolusha tolusha mentioned this issue Jul 7, 2021
24 tasks
@tolusha
Copy link
Contributor

tolusha commented Jul 7, 2021

@l0rd
The idea is to use Ingress v1 only if platform supports it otherwise Ingress v1beta1 will be used.
So, Eclipse Che will still work on older versions of Kubernetes.

@tolusha
Copy link
Contributor

tolusha commented Jul 7, 2021

this issue depends on #19466

@tolusha tolusha added this to the 7.34 milestone Jul 8, 2021
@tolusha tolusha added sprint/next kind/enhancement A feature request - must adhere to the feature request template. area/che-server and removed sprint/current kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jul 20, 2021
@tolusha tolusha removed this from the 7.34 milestone Jul 20, 2021
@tolusha tolusha changed the title [Che Operator] Ingress apiversion v1beta1 will be deprecated in v1.22 Migrate manifests and API clients to use the networking.k8s.io/v1 API version Jul 20, 2021
@sleshchenko
Copy link
Member

related issue on DWO side devfile/devworkspace-operator#543

@tolusha
Copy link
Contributor

tolusha commented Sep 1, 2021

Remaining task #20298

@apupier
Copy link
Contributor

apupier commented Sep 7, 2021

For information, Che is not working with latest released Kubernetes 1.22.0 as this deprecated extensions/v1beta1 has been removed.
Kubernetes 1.22.0 will be the base of OpenShift 4.9.

@tolusha
Copy link
Contributor

tolusha commented Sep 7, 2021

@apupier
I've just checked next version.
Everything works fine.
Which version were you talking about?

@apupier
Copy link
Contributor

apupier commented Sep 7, 2021

Which version were you talking about?

latest released Eclipse Che 7.35.2

@tolusha tolusha modified the milestones: 7.35, 7.36 Sep 8, 2021
@tolusha
Copy link
Contributor

tolusha commented Sep 8, 2021

Should work for upcoming 7.36.0 (and next) now.

@tolusha tolusha closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to installation, including offline/air gap and initial setup kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

9 participants