Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer, I want to have a link automatically generated for verifying a PR on workspaces.openshift.com #20155

Closed
ibuziuk opened this issue Jul 20, 2021 · 9 comments
Assignees
Labels
area/hosted-che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Jul 20, 2021

Is your task related to a problem? Please describe.

As a developer, I want to have a link automatically generated for verifying a PR on workspaces.openshift.com:

Describe the solution you'd like

  • a developer opens a PR to one of the Eclipse Che related repositories
  • a link to workspaces.openshift.com is automatically generated in the following format:

https://workspaces.openshift.com#https://github.com/fork/repo/tree/branch e.g.

Contribute

Describe alternatives you've considered

N/A

Additional context

ideally, the Try it on Eclipse Che hosted by Red Hat link should be generated for every Eclipse Che related repo and every PR

@ibuziuk ibuziuk added kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/next severity/P1 Has a major impact to usage or development of the system. area/hosted-che labels Jul 20, 2021
@nickboldt nickboldt added the area/doc Issues related to documentation label Jul 20, 2021
@nickboldt
Copy link
Contributor

Try it on Eclipse Che hosted by Red Hat

Should the link be labelled "Open this PR in Developer Workspace" ? or is "Eclipse Che hosted by Red Hat" the official name?

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 20, 2021

Eclipse Che hosted by Red Hat is the official name - https://www.eclipse.org/che/docs/che-7/hosted-che/hosted-che/
However, I think we should end up generating just the following badge:

Contribute

@ibuziuk ibuziuk changed the title As a developer, I want to have a link automatically generated or verifying a PR on workspaces.openshift.com As a developer, I want to have a link automatically generated for verifying a PR on workspaces.openshift.com Jul 21, 2021
@l0rd
Copy link
Contributor

l0rd commented Jul 21, 2021

cc @benoitf

@benoitf
Copy link
Contributor

benoitf commented Jul 21, 2021

would be nice to have badge available on shields.io

@l0rd
Copy link
Contributor

l0rd commented Jul 21, 2021

would be nice to have badge available on shields.io

There is a simple icon for Che. So we can use something like https://img.shields.io/static/v1?logo=eclipse-che&label=label&message=message. For example:

@ibuziuk
Copy link
Member Author

ibuziuk commented Aug 10, 2021

The action has been created

on: pull_request_target

jobs:
  comment_pr:
    runs-on: ubuntu-20.04
    name: Try the PR on Eclipse Che hosted by Red Hat
    steps:
      - name: Comment PR
        uses: thollander/actions-comment-pull-request@1.0.1
        with:
          message: 'Try the PR on Eclipse Che hosted by Red Hat [![Contribute](https://img.shields.io/badge/Eclipse_Che-Hosted%20by%20Red%20Hat-525C86?logo=eclipse-che&labelColor=FDB940)](https://workspaces.openshift.com#https://github.com/${{ github.event.pull_request.head.repo.full_name }}/tree/${{ github.head_ref }})'
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Each Eclipse Che repo should have it in place. Example eclipse-che/che-docs#2092

NOTE: it is important to use pull_request_target trigger due to the permission issues with forks:

@ibuziuk ibuziuk removed the area/doc Issues related to documentation label Aug 10, 2021
@ibuziuk
Copy link
Member Author

ibuziuk commented Aug 18, 2021

Moving to the next sprint. Open questions after the sprint review:

  • Custom GitHub action
  • GitHub App / marketplace
  • Blog post / documentation

@ibuziuk ibuziuk modified the milestones: 7.35, 7.36 Aug 18, 2021
@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 7, 2021

The action has been published -
Going to close the issue once redhat-actions/try-in-web-ide#7 is fixed + the docs are published on the https://www.eclipse.org/che/docs/che-7/hosted-che/hosted-che/

@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 13, 2021

@ibuziuk ibuziuk closed this as completed Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hosted-che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants