Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database migration script should be run automatically when user enables DevWorkspace engine on the 'all-namespace' channel #20722

Closed
ibuziuk opened this issue Nov 3, 2021 · 3 comments
Closed

Database migration script should be run automatically when user enables DevWorkspace engine on the 'all-namespace' channel #20722

ibuziuk opened this issue Nov 3, 2021 · 3 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Nov 3, 2021 •
edited
Loading

Is your task related to a problem? Please describe

The investigation related to the new account creation is finished as part of the #20629, and the solution is the execution of the database migration script #20629 (comment)

As part of this issue, the migration script should be integrated into the operator, and run automatically only once when the user enables DevWorkspace engine after switching to the all-namespace channel.

Describe the solution you'd like

the migration script should be integrated into the operator and run automatically when the user enables DevWorkspace engine after switching to the all-namespace channel. Potential flow

  1. Eclipse Che is running in the single-namespace mode with che-server engine enabled
  2. Admin switches the operator to the all-namespace mode (manual subscription / csv removal + installing operator from scratch in the 'all-namespace' mode).
  3. Admin enables the DevWorkspace engine
  4. Operator is running the database script automatically + creates a cm as an indicator that the script has been executed
  5. Eclipse Che is running in the all-namespace mode with the DevWrokspace engine enabled (it is not possible to run che-server based workspaces anymore)

N/B the script should be run only once (it should be possible to create a cm as an indicator of the successful miigration).

Describe alternatives you've considered

N/A

Additional context

Related issue with new account creation - #20629
Details regarding the migration script - #20629 (comment)
@ibuziuk ibuziuk added kind/task Internal things, technical debt, and to-do tasks to be performed. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator severity/P1 Has a major impact to usage or development of the system. labels Nov 3, 2021
@ibuziuk ibuziuk changed the title Database migration script should be run automatically when user enables DevWorkspace enginge on 'tech-preview-stable-all-namespace` channel Database migration script should be run automatically when user enables DevWorkspace enginge on the 'all-namespace` channel Nov 3, 2021
@ibuziuk ibuziuk changed the title Database migration script should be run automatically when user enables DevWorkspace enginge on the 'all-namespace` channel Database migration script should be run automatically when user enables DevWorkspace enginge on the 'all-namespace' channel Nov 3, 2021
@tolusha
Copy link
Contributor

tolusha commented Nov 3, 2021

Sorry, I missed that call.
-1 from my side. Operator knows nothing about channels.
What is the problem of running script as part of migration guide?
We already need to create subscription, so script can be run before that.

@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 4, 2021

well, every single customer will need to follow the low-level instructions for migration that is the only concern. On the other hand, performing the migration manually would allow more control and flexibility. @l0rd wdyt? can we close this issue in favour of #20614 as part of which the migration documentation will be provided for upstream and downstream.

@tolusha tolusha added severity/P2 Has a minor but important impact to the usage or development of the system. and removed sprint/next severity/P1 Has a major impact to usage or development of the system. labels Nov 9, 2021
@ibuziuk ibuziuk changed the title Database migration script should be run automatically when user enables DevWorkspace enginge on the 'all-namespace' channel Database migration script should be run automatically when user enables DevWorkspace engine on the 'all-namespace' channel Nov 10, 2021
@tolusha
Copy link
Contributor

tolusha commented Nov 11, 2021

We agreed to move migration script into a doc to have completely manual migration guide.

@tolusha tolusha closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibuziuk @tolusha