Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject user kubeconfig into Che workspaces with DevWorkspace enabled #20782

Closed
l0rd opened this issue Nov 16, 2021 · 4 comments
Closed

Inject user kubeconfig into Che workspaces with DevWorkspace enabled #20782

l0rd opened this issue Nov 16, 2021 · 4 comments
Assignees
Labels
area/dashboard area/devworkspace-operator area/machine-exec kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current

Comments

@l0rd
Copy link
Contributor

l0rd commented Nov 16, 2021

Is your enhancement related to a problem? Please describe

In current Che workspaces with DevWorkspace disabled, when the OpenShift connector starts, authentication to the OpenShift API is done automatically.

This mechanism has 2 problems:

  1. It's fragile and intrusive Openshift autologin should help the user if the browser blocking popups #16930
  2. It doesn't work when DevWorkspace is enabled

Describe the solution you'd like

Che should inject the Kubernetes configuration of the user in the workspace containers at workspace startup. The mechanism should be the one used by the OpenShift console for the Web Terminal DevWorkspace.

The OpenShift connector should not need to use che-theia-openshift-auth anymore as users are already authenticated.

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Nov 16, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 16, 2021
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. area/dashboard area/machine-exec area/devworkspace-operator and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 16, 2021
@l0rd l0rd changed the title Automatic inject kubeconfig into Che workspaces with DevWorkspace enabled Inject user kubeconfig into Che workspaces with DevWorkspace enabled Nov 16, 2021
@ibuziuk
Copy link
Member

ibuziuk commented Dec 1, 2021

@l0rd are you ok with postponing this for DevWorkspace feature freeze?

@l0rd
Copy link
Contributor Author

l0rd commented Dec 2, 2021

This is important. The openshift-connector requires it to login the user automatically. Not having it means having a regression that will break some Red Hat workshops. However, if including it in current sprint is not realistic, we can postpone it for later (Che 7.43 / CRW 2.16). cc @svor

@svor
Copy link
Contributor

svor commented Dec 2, 2021

@ibuziuk @l0rd should it be removed from the milestone STEP3 ?

@l0rd
Copy link
Contributor Author

l0rd commented Jan 7, 2022

@JPinkney can we close this issue?

@JPinkney JPinkney closed this as completed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/devworkspace-operator area/machine-exec kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

5 participants