Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShell VS Code extension failed to start #21626

Closed
Tracked by #21615
azatsarynnyy opened this issue Aug 9, 2022 · 12 comments
Closed
Tracked by #21615

PowerShell VS Code extension failed to start #21626

azatsarynnyy opened this issue Aug 9, 2022 · 12 comments
Assignees
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Aug 9, 2022

Is your task related to a problem? Please describe

PowerShell VS Code extension failed to start in Che-Code.

Describe the solution you'd like

Need to investigate why the extension waits for the session file continuously.

Describe alternatives you've considered

No response

Additional context

8/16/2022 1:29:22 PM [NORMAL] - Visual Studio Code v1.71.0 64-bit
8/16/2022 1:29:22 PM [NORMAL] - PowerShell Extension v2022.7.2
8/16/2022 1:29:22 PM [NORMAL] - Operating System: Linux 64-bit
8/16/2022 1:29:24 PM [NORMAL] - Language server starting --
8/16/2022 1:29:24 PM [NORMAL] -     PowerShell executable: /usr/bin/pwsh
8/16/2022 1:29:24 PM [NORMAL] -     PowerShell args: -NoProfile -EncodedCommand SQBtAHAAbwByAHQALQBNAG8AZAB1AGwAZQAgACcALwBjAGgAZQBjAG8AZABlAC8AcgBlAG0AbwB0AGUALwBlAHgAdABlAG4AcwBpAG8AbgBzAC8AbQBzAC0AdgBzAGMAbwBkAGUALgBwAG8AdwBlAHIAcwBoAGUAbABsAC0AMgAwADIAMgAuADcALgAyAC8AbQBvAGQAdQBsAGUAcwAvAFAAbwB3AGUAcgBTAGgAZQBsAGwARQBkAGkAdABvAHIAUwBlAHIAdgBpAGMAZQBzAC8AUABvAHcAZQByAFMAaABlAGwAbABFAGQAaQB0AG8AcgBTAGUAcgB2AGkAYwBlAHMALgBwAHMAZAAxACcAOwAgAFMAdABhAHIAdAAtAEUAZABpAHQAbwByAFMAZQByAHYAaQBjAGUAcwAgAC0ASABvAHMAdABOAGEAbQBlACAAJwBWAGkAcwB1AGEAbAAgAFMAdAB1AGQAaQBvACAAQwBvAGQAZQAgAEgAbwBzAHQAJwAgAC0ASABvAHMAdABQAHIAbwBmAGkAbABlAEkAZAAgACcATQBpAGMAcgBvAHMAbwBmAHQALgBWAFMAQwBvAGQAZQAnACAALQBIAG8AcwB0AFYAZQByAHMAaQBvAG4AIAAnADIAMAAyADIALgA3AC4AMgAnACAALQBBAGQAZABpAHQAaQBvAG4AYQBsAE0AbwBkAHUAbABlAHMAIABAACgAJwBQAG8AdwBlAHIAUwBoAGUAbABsAEUAZABpAHQAbwByAFMAZQByAHYAaQBjAGUAcwAuAFYAUwBDAG8AZABlACcAKQAgAC0AQgB1AG4AZABsAGUAZABNAG8AZAB1AGwAZQBzAFAAYQB0AGgAIAAnAC8AYwBoAGUAYwBvAGQAZQAvAHIAZQBtAG8AdABlAC8AZQB4AHQAZQBuAHMAaQBvAG4AcwAvAG0AcwAtAHYAcwBjAG8AZABlAC4AcABvAHcAZQByAHMAaABlAGwAbAAtADIAMAAyADIALgA3AC4AMgAvAG0AbwBkAHUAbABlAHMAJwAgAC0ARQBuAGEAYgBsAGUAQwBvAG4AcwBvAGwAZQBSAGUAcABsACAALQBTAHQAYQByAHQAdQBwAEIAYQBuAG4AZQByACAAIgBQAG8AdwBlAHIAUwBoAGUAbABsACAARQB4AHQAZQBuAHMAaQBvAG4AIAB2ADIAMAAyADIALgA3AC4AMgAKAEMAbwBwAHkAcgBpAGcAaAB0ACAAKABjACkAIABNAGkAYwByAG8AcwBvAGYAdAAgAEMAbwByAHAAbwByAGEAdABpAG8AbgAuAAoACgBoAHQAdABwAHMAOgAvAC8AYQBrAGEALgBtAHMALwB2AHMAYwBvAGQAZQAtAHAAbwB3AGUAcgBzAGgAZQBsAGwACgBUAHkAcABlACAAJwBoAGUAbABwACcAIAB0AG8AIABnAGUAdAAgAGgAZQBsAHAALgAKACIAIAAtAEwAbwBnAEwAZQB2AGUAbAAgACcATgBvAHIAbQBhAGwAJwAgAC0ATABvAGcAUABhAHQAaAAgACcALwBjAGgAZQBjAG8AZABlAC8AcgBlAG0AbwB0AGUALwBkAGEAdABhAC8AVQBzAGUAcgAvAGcAbABvAGIAYQBsAFMAdABvAHIAYQBnAGUALwBtAHMALQB2AHMAYwBvAGQAZQAuAHAAbwB3AGUAcgBzAGgAZQBsAGwALwBsAG8AZwBzAC8AMQA2ADYAMAA2ADUANgA1ADYAMgAtAHMAbwBtAGUAVgBhAGwAdQBlAC4AcwBlAHMAcwBpAG8AbgBJAGQALwBFAGQAaQB0AG8AcgBTAGUAcgB2AGkAYwBlAHMALgBsAG8AZwAnACAALQBTAGUAcwBzAGkAbwBuAEQAZQB0AGEAaQBsAHMAUABhAHQAaAAgACcALwBjAGgAZQBjAG8AZABlAC8AcgBlAG0AbwB0AGUALwBkAGEAdABhAC8AVQBzAGUAcgAvAGcAbABvAGIAYQBsAFMAdABvAHIAYQBnAGUALwBtAHMALQB2AHMAYwBvAGQAZQAuAHAAbwB3AGUAcgBzAGgAZQBsAGwALwBzAGUAcwBzAGkAbwBuAHMALwBQAFMARQBTAC0AVgBTAEMAbwBkAGUALQB1AG4AZABlAGYAaQBuAGUAZAAtADgANgA0ADgANwAzAC4AagBzAG8AbgAnACAALQBGAGUAYQB0AHUAcgBlAEYAbABhAGcAcwAgAEAAKAApACAA
8/16/2022 1:29:24 PM [NORMAL] -     PowerShell Editor Services args: Import-Module '/checode/remote/extensions/ms-vscode.powershell-2022.7.2/modules/PowerShellEditorServices/PowerShellEditorServices.psd1'; Start-EditorServices -HostName 'Visual Studio Code Host' -HostProfileId 'Microsoft.VSCode' -HostVersion '2022.7.2' -AdditionalModules @('PowerShellEditorServices.VSCode') -BundledModulesPath '/checode/remote/extensions/ms-vscode.powershell-2022.7.2/modules' -EnableConsoleRepl -StartupBanner "PowerShell Extension v2022.7.2
Copyright (c) Microsoft Corporation.

https://aka.ms/vscode-powershell
Type 'help' to get help.
" -LogLevel 'Normal' -LogPath '/checode/remote/data/User/globalStorage/ms-vscode.powershell/logs/1660656562-someValue.sessionId/EditorServices.log' -SessionDetailsPath '/checode/remote/data/User/globalStorage/ms-vscode.powershell/sessions/PSES-VSCode-undefined-864873.json' -FeatureFlags @() 
8/16/2022 1:29:25 PM [NORMAL] - pwsh started.
8/16/2022 1:29:25 PM [NORMAL] - Waiting for session file 
@azatsarynnyy azatsarynnyy added kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current severity/P1 Has a major impact to usage or development of the system. team/editors area/editor/vscode Issues related to the Code OSS editor of Che labels Aug 9, 2022
@azatsarynnyy azatsarynnyy self-assigned this Aug 9, 2022
@azatsarynnyy azatsarynnyy added this to the 7.53 milestone Aug 9, 2022
@azatsarynnyy
Copy link
Member Author

Previously, I assumed that our machine-exec implementation of the terminal prevented the PowerShell extension from working correctly. But the assumption was not confirmed. Moreover, I prepared the Che-Code build without a machine-exec terminal for testing and the described problem is not reproduced in both cases: with and w/o the machine-exec.

First thing I noticed, the extension is not hanging at startup anymore.

I tried pwsh command. Everything works well.
pwsh

cc @l0rd

@azatsarynnyy
Copy link
Member Author

I just realized I was using the wrong extension 🤦‍♂️
I tested https://open-vsx.org/extension/ms-vscode/powershell-preview instead of https://open-vsx.org/extension/ms-vscode/powershell
I'm going to check it one more time.

@azatsarynnyy
Copy link
Member Author

The result of testing without the machine-exec ⬇️

After installing the PowerShell extension

image

  1. a new Terminal Profile pwsh is contributed to the Launch Profile... menu:

image

  1. after activating the extension (e.g. on opening a *.ps1 file), the PowerShell Extension terminal profile is launched automatically:

image

  1. the editor autocompletion works fine:

image

  1. in the extension's logs, I see no problems reported:
8/18/2022 12:34:25 PM [NORMAL] - Visual Studio Code v1.70.0 64-bit
8/18/2022 12:34:25 PM [NORMAL] - PowerShell Extension v2022.7.2
8/18/2022 12:34:25 PM [NORMAL] - Operating System: Linux 64-bit
8/18/2022 12:34:27 PM [NORMAL] - Language server starting --
8/18/2022 12:34:27 PM [NORMAL] -     PowerShell executable: /usr/bin/pwsh
8/18/2022 12:34:27 PM [NORMAL] -     PowerShell args: -NoProfile -EncodedCommand SQBtAHAAbwByAHQALQBNAG8AZAB1AGwAZQAgACcALwBjAGgAZQBjAG8AZABlAC8AcgBlAG0AbwB0AGUALwBlAHgAdABlAG4AcwBpAG8AbgBzAC8AbQBzAC0AdgBzAGMAbwBkAGUALgBwAG8AdwBlAHIAcwBoAGUAbABsAC0AMgAwADIAMgAuADcALgAyAC8AbQBvAGQAdQBsAGUAcwAvAFAAbwB3AGUAcgBTAGgAZQBsAGwARQBkAGkAdABvAHIAUwBlAHIAdgBpAGMAZQBzAC8AUABvAHcAZQByAFMAaABlAGwAbABFAGQAaQB0AG8AcgBTAGUAcgB2AGkAYwBlAHMALgBwAHMAZAAxACcAOwAgAFMAdABhAHIAdAAtAEUAZABpAHQAbwByAFMAZQByAHYAaQBjAGUAcwAgAC0ASABvAHMAdABOAGEAbQBlACAAJwBWAGkAcwB1AGEAbAAgAFMAdAB1AGQAaQBvACAAQwBvAGQAZQAgAEgAbwBzAHQAJwAgAC0ASABvAHMAdABQAHIAbwBmAGkAbABlAEkAZAAgACcATQBpAGMAcgBvAHMAbwBmAHQALgBWAFMAQwBvAGQAZQAnACAALQBIAG8AcwB0AFYAZQByAHMAaQBvAG4AIAAnADIAMAAyADIALgA3AC4AMgAnACAALQBBAGQAZABpAHQAaQBvAG4AYQBsAE0AbwBkAHUAbABlAHMAIABAACgAJwBQAG8AdwBlAHIAUwBoAGUAbABsAEUAZABpAHQAbwByAFMAZQByAHYAaQBjAGUAcwAuAFYAUwBDAG8AZABlACcAKQAgAC0AQgB1AG4AZABsAGUAZABNAG8AZAB1AGwAZQBzAFAAYQB0AGgAIAAnAC8AYwBoAGUAYwBvAGQAZQAvAHIAZQBtAG8AdABlAC8AZQB4AHQAZQBuAHMAaQBvAG4AcwAvAG0AcwAtAHYAcwBjAG8AZABlAC4AcABvAHcAZQByAHMAaABlAGwAbAAtADIAMAAyADIALgA3AC4AMgAvAG0AbwBkAHUAbABlAHMAJwAgAC0ARQBuAGEAYgBsAGUAQwBvAG4AcwBvAGwAZQBSAGUAcABsACAALQBTAHQAYQByAHQAdQBwAEIAYQBuAG4AZQByACAAIgBQAG8AdwBlAHIAUwBoAGUAbABsACAARQB4AHQAZQBuAHMAaQBvAG4AIAB2ADIAMAAyADIALgA3AC4AMgAKAEMAbwBwAHkAcgBpAGcAaAB0ACAAKABjACkAIABNAGkAYwByAG8AcwBvAGYAdAAgAEMAbwByAHAAbwByAGEAdABpAG8AbgAuAAoACgBoAHQAdABwAHMAOgAvAC8AYQBrAGEALgBtAHMALwB2AHMAYwBvAGQAZQAtAHAAbwB3AGUAcgBzAGgAZQBsAGwACgBUAHkAcABlACAAJwBoAGUAbABwACcAIAB0AG8AIABnAGUAdAAgAGgAZQBsAHAALgAKACIAIAAtAEwAbwBnAEwAZQB2AGUAbAAgACcATgBvAHIAbQBhAGwAJwAgAC0ATABvAGcAUABhAHQAaAAgACcALwBjAGgAZQBjAG8AZABlAC8AcgBlAG0AbwB0AGUALwBkAGEAdABhAC8AVQBzAGUAcgAvAGcAbABvAGIAYQBsAFMAdABvAHIAYQBnAGUALwBtAHMALQB2AHMAYwBvAGQAZQAuAHAAbwB3AGUAcgBzAGgAZQBsAGwALwBsAG8AZwBzAC8AMQA2ADYAMAA4ADIANgAwADYANQAtAHMAbwBtAGUAVgBhAGwAdQBlAC4AcwBlAHMAcwBpAG8AbgBJAGQALwBFAGQAaQB0AG8AcgBTAGUAcgB2AGkAYwBlAHMALgBsAG8AZwAnACAALQBTAGUAcwBzAGkAbwBuAEQAZQB0AGEAaQBsAHMAUABhAHQAaAAgACcALwBjAGgAZQBjAG8AZABlAC8AcgBlAG0AbwB0AGUALwBkAGEAdABhAC8AVQBzAGUAcgAvAGcAbABvAGIAYQBsAFMAdABvAHIAYQBnAGUALwBtAHMALQB2AHMAYwBvAGQAZQAuAHAAbwB3AGUAcgBzAGgAZQBsAGwALwBzAGUAcwBzAGkAbwBuAHMALwBQAFMARQBTAC0AVgBTAEMAbwBkAGUALQB1AG4AZABlAGYAaQBuAGUAZAAtADcAOAA2ADYANwA1AC4AagBzAG8AbgAnACAALQBGAGUAYQB0AHUAcgBlAEYAbABhAGcAcwAgAEAAKAApACAA
8/18/2022 12:34:27 PM [NORMAL] -     PowerShell Editor Services args: Import-Module '/checode/remote/extensions/ms-vscode.powershell-2022.7.2/modules/PowerShellEditorServices/PowerShellEditorServices.psd1'; Start-EditorServices -HostName 'Visual Studio Code Host' -HostProfileId 'Microsoft.VSCode' -HostVersion '2022.7.2' -AdditionalModules @('PowerShellEditorServices.VSCode') -BundledModulesPath '/checode/remote/extensions/ms-vscode.powershell-2022.7.2/modules' -EnableConsoleRepl -StartupBanner "PowerShell Extension v2022.7.2
Copyright (c) Microsoft Corporation.

https://aka.ms/vscode-powershell
Type 'help' to get help.
" -LogLevel 'Normal' -LogPath '/checode/remote/data/User/globalStorage/ms-vscode.powershell/logs/1660826065-someValue.sessionId/EditorServices.log' -SessionDetailsPath '/checode/remote/data/User/globalStorage/ms-vscode.powershell/sessions/PSES-VSCode-undefined-786675.json' -FeatureFlags @() 
8/18/2022 12:34:27 PM [NORMAL] - pwsh started.
8/18/2022 12:34:27 PM [NORMAL] - Waiting for session file
8/18/2022 12:34:29 PM [NORMAL] - Session file found
8/18/2022 12:34:29 PM [NORMAL] - Registering terminal close callback
8/18/2022 12:34:29 PM [NORMAL] - Registering terminal PID log callback
8/18/2022 12:34:29 PM [NORMAL] - pwsh PID: 1180
8/18/2022 12:34:29 PM [NORMAL] - Language server started.
8/18/2022 12:34:29 PM [NORMAL] - {"status":"started","languageServiceTransport":"NamedPipe","languageServicePipeName":"/tmp/CoreFxPipe_PSES_j0iwodeg.y34","debugServiceTransport":"NamedPipe","debugServicePipeName":"/tmp/CoreFxPipe_PSES_yzjscaht.emu"}
8/18/2022 12:34:29 PM [NORMAL] - Connecting to language service on pipe /tmp/CoreFxPipe_PSES_j0iwodeg.y34...
8/18/2022 12:34:29 PM [NORMAL] - Language service connected.

@azatsarynnyy
Copy link
Member Author

The result of testing with the machine-exec ⬇️

After installing the PowerShell extension

image

  1. there's no pwsh Terminal Profile contributed:

image

  1. after activating the extension (e.g. on opening a *.ps1 file), the PowerShell Extension terminal profile is failed to launch automatically - just an empty panel is shown:

image

  1. consequently, the editor autocompletion features didn't work right:

image

  1. in the extension's logs, I see some problems are reported:
8/18/2022 1:02:49 PM [NORMAL] - Visual Studio Code v1.71.0 64-bit
8/18/2022 1:02:49 PM [NORMAL] - PowerShell Extension v2022.7.2
8/18/2022 1:02:49 PM [NORMAL] - Operating System: Linux 64-bit
8/18/2022 1:02:50 PM [NORMAL] - Language server starting --
8/18/2022 1:02:50 PM [NORMAL] -     PowerShell executable: /usr/bin/pwsh
8/18/2022 1:02:50 PM [NORMAL] -     PowerShell args: -NoProfile -EncodedCommand SQBtAHAAbwByAHQALQBNAG8AZAB1AGwAZQAgACcALwBjAGgAZQBjAG8AZABlAC8AcgBlAG0AbwB0AGUALwBlAHgAdABlAG4AcwBpAG8AbgBzAC8AbQBzAC0AdgBzAGMAbwBkAGUALgBwAG8AdwBlAHIAcwBoAGUAbABsAC0AMgAwADIAMgAuADcALgAyAC8AbQBvAGQAdQBsAGUAcwAvAFAAbwB3AGUAcgBTAGgAZQBsAGwARQBkAGkAdABvAHIAUwBlAHIAdgBpAGMAZQBzAC8AUABvAHcAZQByAFMAaABlAGwAbABFAGQAaQB0AG8AcgBTAGUAcgB2AGkAYwBlAHMALgBwAHMAZAAxACcAOwAgAFMAdABhAHIAdAAtAEUAZABpAHQAbwByAFMAZQByAHYAaQBjAGUAcwAgAC0ASABvAHMAdABOAGEAbQBlACAAJwBWAGkAcwB1AGEAbAAgAFMAdAB1AGQAaQBvACAAQwBvAGQAZQAgAEgAbwBzAHQAJwAgAC0ASABvAHMAdABQAHIAbwBmAGkAbABlAEkAZAAgACcATQBpAGMAcgBvAHMAbwBmAHQALgBWAFMAQwBvAGQAZQAnACAALQBIAG8AcwB0AFYAZQByAHMAaQBvAG4AIAAnADIAMAAyADIALgA3AC4AMgAnACAALQBBAGQAZABpAHQAaQBvAG4AYQBsAE0AbwBkAHUAbABlAHMAIABAACgAJwBQAG8AdwBlAHIAUwBoAGUAbABsAEUAZABpAHQAbwByAFMAZQByAHYAaQBjAGUAcwAuAFYAUwBDAG8AZABlACcAKQAgAC0AQgB1AG4AZABsAGUAZABNAG8AZAB1AGwAZQBzAFAAYQB0AGgAIAAnAC8AYwBoAGUAYwBvAGQAZQAvAHIAZQBtAG8AdABlAC8AZQB4AHQAZQBuAHMAaQBvAG4AcwAvAG0AcwAtAHYAcwBjAG8AZABlAC4AcABvAHcAZQByAHMAaABlAGwAbAAtADIAMAAyADIALgA3AC4AMgAvAG0AbwBkAHUAbABlAHMAJwAgAC0ARQBuAGEAYgBsAGUAQwBvAG4AcwBvAGwAZQBSAGUAcABsACAALQBTAHQAYQByAHQAdQBwAEIAYQBuAG4AZQByACAAIgBQAG8AdwBlAHIAUwBoAGUAbABsACAARQB4AHQAZQBuAHMAaQBvAG4AIAB2ADIAMAAyADIALgA3AC4AMgAKAEMAbwBwAHkAcgBpAGcAaAB0ACAAKABjACkAIABNAGkAYwByAG8AcwBvAGYAdAAgAEMAbwByAHAAbwByAGEAdABpAG8AbgAuAAoACgBoAHQAdABwAHMAOgAvAC8AYQBrAGEALgBtAHMALwB2AHMAYwBvAGQAZQAtAHAAbwB3AGUAcgBzAGgAZQBsAGwACgBUAHkAcABlACAAJwBoAGUAbABwACcAIAB0AG8AIABnAGUAdAAgAGgAZQBsAHAALgAKACIAIAAtAEwAbwBnAEwAZQB2AGUAbAAgACcATgBvAHIAbQBhAGwAJwAgAC0ATABvAGcAUABhAHQAaAAgACcALwBjAGgAZQBjAG8AZABlAC8AcgBlAG0AbwB0AGUALwBkAGEAdABhAC8AVQBzAGUAcgAvAGcAbABvAGIAYQBsAFMAdABvAHIAYQBnAGUALwBtAHMALQB2AHMAYwBvAGQAZQAuAHAAbwB3AGUAcgBzAGgAZQBsAGwALwBsAG8AZwBzAC8AMQA2ADYAMAA4ADIANwA3ADYAOQAtAHMAbwBtAGUAVgBhAGwAdQBlAC4AcwBlAHMAcwBpAG8AbgBJAGQALwBFAGQAaQB0AG8AcgBTAGUAcgB2AGkAYwBlAHMALgBsAG8AZwAnACAALQBTAGUAcwBzAGkAbwBuAEQAZQB0AGEAaQBsAHMAUABhAHQAaAAgACcALwBjAGgAZQBjAG8AZABlAC8AcgBlAG0AbwB0AGUALwBkAGEAdABhAC8AVQBzAGUAcgAvAGcAbABvAGIAYQBsAFMAdABvAHIAYQBnAGUALwBtAHMALQB2AHMAYwBvAGQAZQAuAHAAbwB3AGUAcgBzAGgAZQBsAGwALwBzAGUAcwBzAGkAbwBuAHMALwBQAFMARQBTAC0AVgBTAEMAbwBkAGUALQB1AG4AZABlAGYAaQBuAGUAZAAtADgANAA5ADYANgAzAC4AagBzAG8AbgAnACAALQBGAGUAYQB0AHUAcgBlAEYAbABhAGcAcwAgAEAAKAApACAA
8/18/2022 1:02:50 PM [NORMAL] -     PowerShell Editor Services args: Import-Module '/checode/remote/extensions/ms-vscode.powershell-2022.7.2/modules/PowerShellEditorServices/PowerShellEditorServices.psd1'; Start-EditorServices -HostName 'Visual Studio Code Host' -HostProfileId 'Microsoft.VSCode' -HostVersion '2022.7.2' -AdditionalModules @('PowerShellEditorServices.VSCode') -BundledModulesPath '/checode/remote/extensions/ms-vscode.powershell-2022.7.2/modules' -EnableConsoleRepl -StartupBanner "PowerShell Extension v2022.7.2
Copyright (c) Microsoft Corporation.

https://aka.ms/vscode-powershell
Type 'help' to get help.
" -LogLevel 'Normal' -LogPath '/checode/remote/data/User/globalStorage/ms-vscode.powershell/logs/1660827769-someValue.sessionId/EditorServices.log' -SessionDetailsPath '/checode/remote/data/User/globalStorage/ms-vscode.powershell/sessions/PSES-VSCode-undefined-849663.json' -FeatureFlags @() 
8/18/2022 1:02:50 PM [NORMAL] - pwsh started.
8/18/2022 1:02:50 PM [NORMAL] - Waiting for session file
8/18/2022 1:06:50 PM [NORMAL] - Timed out waiting for session file to appear.
8/18/2022 1:06:50 PM [NORMAL] - Language server startup failed.
8/18/2022 1:06:50 PM [ERROR] - The language service could not be started: 
8/18/2022 1:06:50 PM [ERROR] - Error: Timed out waiting for session file to appear.

Also, the notifications:

image

@azatsarynnyy
Copy link
Member Author

Actually, my previous assumption is confirmed 🙂
Obviously, all the mentioned problems with running the PowerShell extension are caused by our implementation of the machine-exec support.

To fix all these problems, we can disable the machine-exec support until we decide if we really needed it, or until we rework it and make sure our implementation works well with the existing terminal-related functionality in VS Code.

Disabling the machine-exec support means:

  • there will be no easy way to open a terminal to a non-editor container
  • there will be no support for running the Devfile Commands as the VS Code Tasks (it will require some reworking)

Also, disabling the machine-exec support should fix the problems with running non-che tasks (like shell, process, npm, etc. #21466

So, I think it would be better if we disable the machine-exec support (as it's currently implemented) to get the VS Code features to work correctly. And, probably, return back to that topic later taking into account all these problems we've discovered.

@l0rd @benoitf WDYT?

@l0rd
Copy link
Contributor

l0rd commented Aug 18, 2022

+1 to drop the machine-exec support. I expect that then we can also re-enable shell integration.

But being able to open a terminal on a non-editor container and supporting Devfile commands as VS Code tasks are 2 features that we cannot drop.

If possible I would like to make the drop of machine-exec step by step: 1) drop machine-exec support for the default terminal (but still use machine exec for non-editor containers and for tasks) 2) support devfile commands as tasks without using machine-exec (but still use machine exec for non-editor containers) 3) support terminal on non-editor containers without machine-exec.

@l0rd
Copy link
Contributor

l0rd commented Aug 18, 2022

We should also verify what was mentioned by @ibuziuk: user kubeconfig should continue to be automatically injected when starting a workspace from the dashboard.

@l0rd
Copy link
Contributor

l0rd commented Aug 18, 2022

And thanks @azatsarynnyy, great investigation.

@azatsarynnyy
Copy link
Member Author

The work on the new terminal extension is tracked in the issue #21673

@l0rd
Copy link
Contributor

l0rd commented Oct 6, 2022

@azatsarynnyy can we close this? Asking to decide if we can include it in the 7.55 release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

2 participants