Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To start JetBrains IDEs, use post-start rather than overrideing the entrypoint #22034

Closed
l0rd opened this issue Mar 6, 2023 · 1 comment
Closed
Assignees
Labels
area/editors kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Mar 6, 2023

Is your enhancement related to a problem? Please describe

The editor command overrides the tooling container entrypoint:

  • if the user had specified the container command in his devfile
  • if the tooling container had a specific entrypoint + command

This blocks services as kubedock (to support docker run) to be run at startup in tooling containers.

Describe the solution you'd like

The solution is the same as the one provided for VS Code, remove the command in the editor container and a an init-che-code-command among the devfile commands associated to a post-start event:

(...)
  commands:
      - id: init-che-code-command
        exec:
          component: che-code-runtime-description
          commandLine: 'nohup /checode/entrypoint-volume.sh > /checode/entrypoint-logs.txt 2>&1 &'
  events:
      postStart:
        - init-che-code-command
@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Mar 6, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 6, 2023
@l0rd l0rd mentioned this issue Mar 6, 2023
7 tasks
@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. area/editors team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 6, 2023
@RomanNikitenko RomanNikitenko self-assigned this Mar 22, 2023
@RomanNikitenko RomanNikitenko added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 22, 2023
@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 24, 2023
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Mar 30, 2023
@l0rd l0rd added this to the 7.63 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editors kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.
Projects
None yet
Development

No branches or pull requests

5 participants