Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che does not implement LSP 2.x as stated in doc #4343

Closed
tsmaeder opened this issue Mar 7, 2017 · 4 comments
Closed

Che does not implement LSP 2.x as stated in doc #4343

tsmaeder opened this issue Mar 7, 2017 · 4 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Mar 7, 2017

The documentation at https://www.eclipse.org/che/docs/plugins/languageserver/index.html states that CHE implements LSP 2.x, but if you look at the definition textDocument/documentHighlight (https://github.com/Microsoft/language-server-protocol/blob/master/versions/protocol-2-x.md#textDocument_documentHighlight), you can see that there is a single document highlight returned, not an array of document highlights. This was correct in the 1.0 version of LSP (https://github.com/Microsoft/language-server-protocol/blob/master/versions/protocol-1-x.md), but not 2.x

@TylerJewell TylerJewell added kind/bug Outline of a bug - must adhere to the bug report template. team/ide severity/P2 Has a minor but important impact to the usage or development of the system. labels Mar 7, 2017
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Mar 7, 2017

This seems to be mandated by the typefox lsp library version used. I'm not quite sure what version of lsp it implements.

@tsmaeder
Copy link
Contributor Author

tsmaeder commented May 3, 2017

Now that we've moved to lsp4j, we could fix this one.

@benoitf benoitf added this to the 5.9.0 milestone May 3, 2017
@benoitf benoitf closed this as completed May 3, 2017
@tsmaeder
Copy link
Contributor Author

tsmaeder commented May 3, 2017

We CAN fix it now, it's not fixed yet. Please reopen this one.

@benoitf benoitf reopened this May 3, 2017
@benoitf benoitf removed this from the 5.9.0 milestone May 3, 2017
@benoitf
Copy link
Contributor

benoitf commented May 3, 2017

sorry I read that it was fixed, not that it has to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants