Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The use of GWT Frame objects is not compatible with the Keycloak integration #5745

Closed
davidfestal opened this issue Jul 19, 2017 · 1 comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@davidfestal
Copy link
Contributor

The use of GWT Frame objects to manage the popup window of both the Java Quick documentation and Java completion documentation is incompatible with the rh-che Keycloak integration that intercepts client-side request submission by overriding the AsyncRequestFactory.

The Frame object creates an new html frame in which the client-side Keycloak-related Javascript code cannot be injected. And thus the http requests sent from these frames don't get the right Keycloak authorization token, and are refused on the server-side by the Keycloak authentication filter.

The use of GWT Frames should probably be replaced by the use of a FlowPanel (just like in the Orion Editor), whose content would be retrieved through an AsyncRequest.

@ghost ghost added kind/task Internal things, technical debt, and to-do tasks to be performed. team/ide labels Jul 20, 2017
@skabashnyuk skabashnyuk mentioned this issue Jul 25, 2017
25 tasks
@skabashnyuk
Copy link
Contributor

Wouldn't fix. For this case, token can be a part of a request. Discussed with @l0rd @gorkem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

2 participants