Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Keycloack account page styles in multiuser Che #6226

Closed
ashumilova opened this issue Sep 12, 2017 · 8 comments
Closed

Adapt Keycloack account page styles in multiuser Che #6226

ashumilova opened this issue Sep 12, 2017 · 8 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Milestone

Comments

@ashumilova
Copy link
Contributor

ashumilova commented Sep 12, 2017

The pages for account management in KeyCloack should have proper styles to fit the general style of Che application, same as for login page.

The links could be found here:
image

The account (profile) page :
image

Change password page:
image

Needed for this issue #5788

@ashumilova ashumilova added kind/enhancement A feature request - must adhere to the feature request template. team/enterprise labels Sep 12, 2017
@skabashnyuk
Copy link
Contributor

@slemeur @mkuznyetsov is this mandatory? If yes it would be nice to take it to the next sprint.

@skabashnyuk skabashnyuk mentioned this issue Sep 12, 2017
25 tasks
@slemeur
Copy link
Contributor

slemeur commented Sep 12, 2017

Yes this is important in order to provide a consistent user flow and experience. Otherwise it will look disconnected.

@slemeur
Copy link
Contributor

slemeur commented Sep 12, 2017

We need to reuse the same styles as the one we have on the dashboard - to stay consistent.

I'm also concerned about the navigation that we will have. Is that possible to move those pages this way?

artboard

@tolusha
Copy link
Contributor

tolusha commented Sep 13, 2017

@slemeur Could you pls clarify the task, what pages have to be refined?

@tolusha tolusha closed this as completed Sep 13, 2017
@tolusha tolusha reopened this Sep 13, 2017
@slemeur
Copy link
Contributor

slemeur commented Sep 13, 2017

Keycloak provides different pages - they can be displayed or not, depending on the configuration of Keycloak.

The goals for us are:
1- Integrate the pages properly inside of the Che's dashboard so that the navigation and the experience remain consistent. (as shown in the mockup)
2- Adopting Dashboard styles for the pages: we need to first handle accountand password, the other ones in a second time.

@tolusha tolusha added status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. sprint/current labels Sep 14, 2017
@mmorhun mmorhun added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Sep 28, 2017
@skabashnyuk
Copy link
Contributor

skabashnyuk commented Sep 28, 2017

Page iframing in a dashboard is not a good idea. Because for Che Keycloak is external service,
it can have different policies for different installations. And more other it can be replaced with a different identity provider. My proposal is to apply Che like styles for Keycloak that we provide and do redirection to his pages. If this is our Keycloak - it will look like Che. If it's external - it will look like his owner wants.

@slemeur
Copy link
Contributor

slemeur commented Sep 28, 2017

@skabashnyuk : Keycloak is external service - but it enables features that are used by end-user of Che. I agree, end-users don't care about Keycloak - they just want a way to manage their account/profile in a seamlessly integrated way, which does not discontinue the user experience (especially the navigation).

@mmorhun mmorhun self-assigned this Sep 29, 2017
@mmorhun mmorhun added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Sep 29, 2017
@mmorhun
Copy link
Contributor

mmorhun commented Oct 3, 2017

Done

@mmorhun mmorhun closed this as completed Oct 3, 2017
@mmorhun mmorhun removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 3, 2017
@tolusha tolusha added this to the 5.19.0 milestone Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

5 participants