Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative implementation of abnormal machine stop and container events propagation #7653

Closed
akorneta opened this issue Nov 30, 2017 · 2 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@akorneta
Copy link
Contributor

Description

Since we have changed the usage of OpenShiftClient from one instance per action to one instance per Che server in the scope of PR, we have one connection pool which has limits for a number of idled connections (it equals to 5 connections by default but it can be overridden). Based on this we have no way to watch pod actions and container events for each workspace with using 2 separate WebSocket connections because at some point we overload the connection pool.
It is possible to use one websocket connection and listen to events of all workspaces if the Che server is configured in the following ways:

  • If Che server is configured to use system admin credentials (username/password or token);
  • If Che server is configured to use a service account.

But there is no clear way how to implement this when Che server uses users' token (like OSIO scenario) or credentials of a user which doesn't have system admin rights.
So it is needed to investigate possible ways how to listen to OpenShift events which will work for all configuration combinations.

@akorneta akorneta added kind/task Internal things, technical debt, and to-do tasks to be performed. team/platform labels Nov 30, 2017
@ghost ghost added the severity/P1 Has a major impact to usage or development of the system. label Apr 9, 2018
@skabashnyuk skabashnyuk added severity/P2 Has a minor but important impact to the usage or development of the system. and removed severity/P1 Has a major impact to usage or development of the system. target/che6 labels Mar 6, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 7, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2019
@che-bot che-bot closed this as completed Sep 17, 2019
@sleshchenko sleshchenko reopened this Nov 1, 2019
@sleshchenko sleshchenko removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 1, 2019
@skabashnyuk skabashnyuk added this to the Backlog - Platform milestone Nov 20, 2019
@che-bot
Copy link
Contributor

che-bot commented May 20, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 20, 2020
@che-bot che-bot closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants