Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language server crashes on hover #271

Closed
slavek-kucera opened this issue Jun 23, 2022 · 2 comments
Closed

Language server crashes on hover #271

slavek-kucera opened this issue Jun 23, 2022 · 2 comments
Assignees
Labels

Comments

@slavek-kucera
Copy link
Contributor

slavek-kucera commented Jun 23, 2022

Describe the bug
The language server may crash when hovering over a macro that had been opened and closed in VSCode.

To Reproduce
Steps to reproduce the behavior:

  1. Open a file with an external macro
  2. Go to macro definition
  3. Close the newly opened window
  4. Hover over the macro in the opencode file

Expected behavior
Do not crash and show useful information about the macro instead.

Additional context
text_data_ref_t looks fundamentally broken - indices are one time computed, but the string content can change.
File versioning should probably be utilized (get_version())

@slavek-kucera slavek-kucera added the bug Something isn't working label Jun 23, 2022
@slavek-kucera slavek-kucera self-assigned this Jun 24, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 1.3.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant