Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use snake_case notation for branch protection rule properties #37

Closed
eclipse-csi-bot opened this issue May 12, 2023 · 3 comments
Closed

Use snake_case notation for branch protection rule properties #37

eclipse-csi-bot opened this issue May 12, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@eclipse-csi-bot
Copy link
Contributor

In GitLab by @netomi on May 12, 2023, 08:44
@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on May 12, 2023, 08:46

Currently, the properties for BranchProtectionRules are using camel case notation as these are the names as returned by graphql. To be consistent with the rest of the settings, we should use snake case instead.

There is some work required to transform the data to / from the provider, but its worth imho.

@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on May 15, 2023, 11:18

mentioned in commit cb1b4a4

@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on May 15, 2023, 12:06

Changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eclipse-csi-bot