New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dpf: Improve and document data-plane-transfer #1519
Merged
bscholtes1A
merged 1 commit into
eclipse-edc:main
from
bscholtes1A:improve-and-document-data-plane-transfer
Jun 27, 2022
Merged
dpf: Improve and document data-plane-transfer #1519
bscholtes1A
merged 1 commit into
eclipse-edc:main
from
bscholtes1A:improve-and-document-data-plane-transfer
Jun 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bscholtes1A
requested review from
ndr-brt,
paullatzelsperger,
jimmarino and
juliapampus
as code owners
June 22, 2022 16:07
28 tasks
bscholtes1A
force-pushed
the
improve-and-document-data-plane-transfer
branch
3 times, most recently
from
June 22, 2022 16:39
33d424e
to
a26e993
Compare
Codecov Report
@@ Coverage Diff @@
## main #1519 +/- ##
==========================================
+ Coverage 67.12% 67.13% +0.01%
==========================================
Files 736 737 +1
Lines 16144 16160 +16
Branches 1050 1055 +5
==========================================
+ Hits 10836 10849 +13
- Misses 4831 4833 +2
- Partials 477 478 +1
Continue to review full report at Codecov.
|
ndr-brt
requested changes
Jun 23, 2022
...ataspaceconnector/transfer/dataplane/sync/flow/ProviderDataPlaneProxyDataFlowController.java
Outdated
Show resolved
Hide resolved
extensions/data-plane-transfer/data-plane-transfer-client/extension.md
Outdated
Show resolved
Hide resolved
...pse/dataspaceconnector/transfer/dataplane/sync/proxy/DataPlaneTransferProxyResolverImpl.java
Outdated
Show resolved
Hide resolved
...clipse/dataspaceconnector/transfer/dataplane/sync/validation/ContractValidationRuleTest.java
Outdated
Show resolved
Hide resolved
...va/org/eclipse/dataspaceconnector/dataplane/api/controller/DataPlanePublicApiController.java
Outdated
Show resolved
Hide resolved
bscholtes1A
force-pushed
the
improve-and-document-data-plane-transfer
branch
from
June 27, 2022 10:02
a26e993
to
5446c86
Compare
...se/dataspaceconnector/transfer/dataplane/sync/api/DataPlaneTokenValidationApiController.java
Fixed
Show fixed
Hide fixed
bscholtes1A
force-pushed
the
improve-and-document-data-plane-transfer
branch
from
June 27, 2022 11:32
5446c86
to
f3e21e4
Compare
ndr-brt
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR improves the
data-plane-transfer
modules in two ways:Why it does that
Solve TODO and improve documentation.
Further notes
Linked Issue(s)
Contributes to #1382
Checklist
no-changelog
)