Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpf: Improve and document data-plane-transfer #1519

Conversation

bscholtes1A
Copy link
Contributor

What this PR changes/adds

This PR improves the data-plane-transfer modules in two ways:

  • it fixes a long-time TODO which was to use the data plane selector also for the Client Pull transfer.
  • it finalizes the documentation of this module.

Why it does that

Solve TODO and improve documentation.

Further notes

Linked Issue(s)

Contributes to #1382

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@bscholtes1A bscholtes1A force-pushed the improve-and-document-data-plane-transfer branch 3 times, most recently from 33d424e to a26e993 Compare June 22, 2022 16:39
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #1519 (5446c86) into main (cfba051) will increase coverage by 0.01%.
The diff coverage is 83.05%.

@@            Coverage Diff             @@
##             main    #1519      +/-   ##
==========================================
+ Coverage   67.12%   67.13%   +0.01%     
==========================================
  Files         736      737       +1     
  Lines       16144    16160      +16     
  Branches     1050     1055       +5     
==========================================
+ Hits        10836    10849      +13     
- Misses       4831     4833       +2     
- Partials      477      478       +1     
Impacted Files Coverage Δ
...ataplane/flow/DataPlaneTransferFlowController.java 90.47% <ø> (ø)
...er/dataplane/sync/DataPlaneTransferSyncConfig.java 0.00% <ø> (ø)
...dataplane/sync/DataPlaneTransferSyncExtension.java 0.00% <0.00%> (ø)
...plane/sync/proxy/DataPlaneProxyTokenDecorator.java 100.00% <ø> (ø)
...xy/DataPlaneTransferProxyReferenceServiceImpl.java 100.00% <ø> (ø)
...aplane/sync/validation/ContractValidationRule.java 87.50% <ø> (ø)
...taplane/api/controller/DataFlowRequestFactory.java 100.00% <ø> (ø)
...ctor/dataplane/api/response/ResponseFunctions.java 83.33% <ø> (ø)
...oxy/DataPlaneTransferConsumerProxyTransformer.java 89.28% <71.42%> (-6.72%) ⬇️
...ataplane/api/validation/TokenValidationClient.java 72.22% <71.42%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfba051...5446c86. Read the comment docs.

@juliapampus juliapampus added this to In progress in Connector via automation Jun 24, 2022
@bscholtes1A bscholtes1A force-pushed the improve-and-document-data-plane-transfer branch from a26e993 to 5446c86 Compare June 27, 2022 10:02
@bscholtes1A bscholtes1A force-pushed the improve-and-document-data-plane-transfer branch from 5446c86 to f3e21e4 Compare June 27, 2022 11:32
@bscholtes1A bscholtes1A requested a review from ndr-brt June 27, 2022 11:43
Connector automation moved this from In progress to Review in progress Jun 27, 2022
@bscholtes1A bscholtes1A merged commit 9da8544 into eclipse-edc:main Jun 27, 2022
Connector automation moved this from Review in progress to Done Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants