New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecal_thread.h misses Destructor #1329

Closed

FlorianReimold opened this issue Jan 23, 2024 · 0 comments · Fixed by #1334

Labels

bug

Milestone

Member

FlorianReimold commented Jan 23, 2024

https://github.com/eclipse-ecal/ecal/blob/master/ecal/core/src/util/ecal_thread.h

The class has an std::thread member variable that is not joined on destruction. Thus, the class needs a destructor calling join

FlorianReimold added the bug label

FlorianReimold added this to the eCAL 5.13 milestone

KerstinKeller mentioned this issue

[Core] Fix: proper destructors / rule of 5 for everything involving std::thread #1334

Merged

KerstinKeller closed this as completed in #1334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment