-pthread is missing

[yurivict]

Describe the bug

ld: error: undefined symbol: pthread_create
>>> referenced by recorder_impl.cpp

[FlorianReimold]

Please provide any information. We cannot help you, like that.

[yurivict]

Here is the log.
FreeBSD 13.1

Please let me know what other info do you need.

[KerstinKeller]

So rec_addon_core links privately to threads:

ecal/app/rec/rec_addon_core/CMakeLists.txt

Lines 52 to 55 in 73f320f

	target_link_libraries(${PROJECT_NAME}
	PRIVATE
	Threads::Threads
	)

and rec_addon_dummy (which actually causes the linker problem) also links privately to rec_addon_core

ecal/app/rec/rec_addon_dummy/CMakeLists.txt

Line 27 in 73f320f

target_link_libraries(${PROJECT_NAME} PRIVATE eCAL::rec_addon_core)

Quetsion now: does rec_addon_dummy implicitly or explicitly creates threads, too?

ecal/app/rec/rec_addon_dummy/src/recorder_impl.cpp

Line 41 in 73f320f

std::thread thread([this]()

It explicitly creates new threads.

So wee neew in rec_addon_dummy/CMakeLists.txt a

find_package(Threads REQUIRED)
target_link_libraries(${PROJECT_NAME} PRIVATE eCAL::rec_addon_core Threads::Threads)

[KerstinKeller]

@yurivict we saw there is now an eCAL FreeBSD port available! 👍 🥳

I also realized that you patched the portable endian file.
https://cgit.freebsd.org/ports/tree/net/ecal/files/patch-lib_ecal__utils_include_ecal__utils_portable__endian.h
Is there something we can add to make it compatible with FreeBSD in general (e.g. with additional #if / #elseif?
Or even better to change it on the original file here?
https://gist.github.com/panzi/6856583#file-portable_endian-h