Missing transformer in data-plane-selector-control-api

[timdah]

Bug Report

Describe the Bug

The getAllDataPlaneInstances endpoint throws a 500 because the DataPlaneInstance --> JsonObject transformer is not registered.

Connector/extensions/data-plane-selector/data-plane-selector-control-api/src/main/java/org/eclipse/edc/connector/dataplane/selector/control/api/DataplaneSelectorControlApiController.java

Lines 103 to 113 in 6e7bb67

	@Override
	@GET
	public JsonArray getAllDataPlaneInstances() {
	var instances = service.getAll().orElseThrow(exceptionMapper(DataPlaneInstance.class));
	return instances.stream()
	.map(i -> transformerRegistry.transform(i, JsonObject.class))
	.filter(Result::succeeded)
	.map(Result::getContent)
	.collect(toJsonArray());
	}

Connector/extensions/data-plane-selector/data-plane-selector-control-api/src/main/java/org/eclipse/edc/connector/dataplane/selector/control/api/DataplaneSelectorControlApiExtension.java

Lines 58 to 66 in 6e7bb67

	@Override
	public void initialize(ServiceExtensionContext context) {
	validatorRegistry.register(DATAPLANE_INSTANCE_TYPE, DataPlaneInstanceValidator.instance());
	typeTransformerRegistry.register(new JsonObjectToDataPlaneInstanceTransformer());
	var controller = new DataplaneSelectorControlApiController(validatorRegistry, typeTransformerRegistry, dataPlaneSelectorService, clock);
	webService.registerResource(ApiContext.CONTROL, controller);
	}

Context Information

• EDC 0.7.0

Possible Implementation

I see two possible solutions:

1. Register the transformer
2. Delete the endpoint, as this is a duplicate of the only endpoint (at least in V3) in the data-plane-selector-api extension.
   

   Connector/extensions/data-plane-selector/data-plane-selector-api/src/main/java/org/eclipse/edc/connector/dataplane/selector/api/v3/DataplaneSelectorApiV3Controller.java

   Lines 32 to 56 in 6e7bb67

   	@Consumes({ MediaType.APPLICATION_JSON })
   	@Produces({ MediaType.APPLICATION_JSON })
   	@Path("/v3/dataplanes")
   	public class DataplaneSelectorApiV3Controller implements DataplaneSelectorApiV3 {
   	private final DataPlaneSelectorService selectionService;
   	private final TypeTransformerRegistry transformerRegistry;
   	public DataplaneSelectorApiV3Controller(DataPlaneSelectorService selectionService, TypeTransformerRegistry transformerRegistry) {
   	this.selectionService = selectionService;
   	this.transformerRegistry = transformerRegistry;
   	}
   	@Override
   	@GET
   	public JsonArray getAllDataPlaneInstances() {
   	var instances = selectionService.getAll().orElseThrow(exceptionMapper(DataPlaneInstance.class));
   	return instances.stream()
   	.map(i -> transformerRegistry.transform(i, JsonObject.class))
   	.filter(Result::succeeded)
   	.map(Result::getContent)
   	.collect(toJsonArray());
   	}
   	}

[github-actions]

Thanks for your contribution 🔥 We will take a look asap 🚀

[ndr-brt]

I vote solution 1, deletion is not correct, because control and management contexts should be kept separated as they serve separate needs, so this duplication is accepted (and I'll say needed) tho.

[paullatzelsperger]

also, generally we shouldn't just remove endpoints without deprecating them first.