Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AudienceResolver should support fallible resolve #4265

Closed
wolf4ood opened this issue Jun 12, 2024 · 0 comments · Fixed by #4266
Closed

AudienceResolver should support fallible resolve #4265

wolf4ood opened this issue Jun 12, 2024 · 0 comments · Fixed by #4266
Assignees
@wolf4ood
Labels
enhancement New feature or request

Comments

@wolf4ood
Copy link
Contributor

Feature Request

Currently the AudienceResolver interface, is defined as

public interface AudienceResolver {
    String resolve(RemoteMessage remoteMessage);
}

but for certain use cases the resolution could fail.
It would be nice for implementors to have a way to outline the resolution error via Result
@wolf4ood wolf4ood added the enhancement New feature or request label Jun 12, 2024
@wolf4ood wolf4ood self-assigned this Jun 12, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label Jun 12, 2024
@wolf4ood wolf4ood removed the triage all new issues awaiting classification label Jun 12, 2024
@wolf4ood wolf4ood mentioned this issue Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolf4ood wolf4ood

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: refactor AudienceResolver with Result as return wolf4ood/DataSpaceConnector
1 participant
@wolf4ood