Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove TransferRequest assetId #4267

Closed
ndr-brt opened this issue Jun 13, 2024 · 0 comments · Fixed by #4269
Closed

remove TransferRequest assetId #4267

ndr-brt opened this issue Jun 13, 2024 · 0 comments · Fixed by #4269
Labels
api Feature related to the (REST) api refactoring Cleaning up code and dependencies

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Jun 13, 2024

Feature Request

As discussed during #4260 , assetId field in TransferRequest is not really needed, because the assetId can be obtained from the ContractAgreement targeted by the contractId.
Removing it the API will be easier and there won't be no need to validate it.

Which Areas Would Be Affected?

transfer process api

Why Is the Feature Desired?

cleanup

Solution Proposal

remove the field from TransferRequest, read it from ContractAgreement, deprecate the field on the API and print a deprecation warning when it's used

@ndr-brt ndr-brt added feature_request New feature request, awaiting triage triage all new issues awaiting classification refactoring Cleaning up code and dependencies api Feature related to the (REST) api and removed feature_request New feature request, awaiting triage triage all new issues awaiting classification labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant