Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified example JBatch exec project #4

Closed
wants to merge 2 commits into from

Conversation

OndroMih
Copy link

This is to simplify the example exec project for JBatch and creation of exec projects for other implementations:

  • moved the default tck properties so that they end up in the JAR artifact and can be accessed from there by the exec project
  • the exec project now reads the default tck properties and adds its own properties. I renamed the properties file so that there's no need to have the overhead of using an ant script to copy it to git-ignored test.properties. I moved it to the config directory so that it's separated from the files created when running the TCK (like Derby log and DB).

As before, the TCK can be run against JBatch simply with mvn verify.

@OndroMih OndroMih requested a review from scottkurz March 23, 2020 00:52
@scottkurz
Copy link
Contributor

Thanks Ondro. The main reason we still have the Ant execution is SigTest. Responding on our dev ML.

Ondrej Mihalyi added 2 commits May 14, 2021 12:20
Signed-off-by: Ondrej Mihalyi <ondrej.mihalyi@payara.fish>
Using sigtestjar from Maven Central by default
A custom sigtestjar can be supplied via the sigtestjar property on command line
Signed-off-by: Ondro Mihalyi <ondrej.mihalyi@payara.fish>
Copy link
Contributor

@scottkurz scottkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx Ondro. Just getting to this. I made some comments and suggested the changes in my PR OndroMih#5 which I made as a PR to your PR branch.

Please take a look. Thanks.

@scottkurz
Copy link
Contributor

Closing this PR.

I added Ondro's core change where we just define a properties file to configure both jbatch + the TCK runtime tests in the newly named: com.ibm.jbatch.tck.exec/config/tck.exec.properties and committed directly to master with:
fa3310b

I removed the sigtest stuff, which we'll have to do later.

Note there are some other TODOs like:

  • update the TCK reference guide now that we have removed batch-tck-testng.properties
  • document the sleep/wait time properties available in the runtime tests (either explicitly, 1-by-1, or just show how to find them if you need to )
    but we'll have to address them later.

@scottkurz scottkurz closed this Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants