Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h:outputScript and h:outputStylesheet "name" attribute is not required #1131

Closed
eclipse-faces-bot opened this issue Aug 15, 2012 · 11 comments
Closed

Comments

@eclipse-faces-bot
Copy link

The facelets documentation javadoc for h:outputScript and h:outputStylesheet indicates that "name" attribute is required, but it is valid to use h:outputScript just to render a <script> tag that surrounds the inner content. For example:

composite:implementation
<h:outputScript rendered="#

{!empty cc.attrs.script}

"><!--
.myCustomScript = #

{cc.attrs.script}

;
//--></h:outputScript>
</composite:implementation>

or

composite:implementation
<h:outputStylesheet rendered="#

{!empty cc.attrs.style}

"><![CDATA[
.myCustomStyle { #

{cc.attrs.style}

}
]]></h:outputStylesheet>
</composite:implementation>

is a valid syntax.

Affected Versions

[2.1]

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Reported by lu4242

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
marfous said:
Please would be possible to increase the priority to the Major and fix the issue in the taglib specification.

See related NetBeans IDE issue:
Bug 216926 - h:outputScript and h:outputStylesheet "name" attribute is not required
http://netbeans.org/bugzilla/show_bug.cgi?id=216926

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
lynx6 said:
wow... this problem need to be fixed, netbeans is showing each file with error parsing.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
Set priority to baseline ahead of JSF 2.3 triage. Priorities will be assigned accurately after this exercise.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@manfredriem said:
Setting priority to Critical

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
File: changebundle.txt
Attached By: @manfredriem

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@manfredriem said:
Applied to 2.3 trunk,

svn commit -m "Fixes https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1131, h:outputScript and h:outputStylesheet "name" attribute is not required"
Sending jsf-api/doc/standard-html-renderkit-base.xml
Sending jsf-ri/conf/share/html_basic.taglib.xml
Transmitting file data ..
Committed revision 15016.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@manfredriem said:
Applied to 2.3 trunk,

svn commit -m "Fixes https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1131, h:outputScript and h:outputStylesheet "name" attribute is not required"
Sending jsf-api/doc/standard-html-renderkit.xml
Transmitting file data .
Committed revision 15017.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Marked as fixed on Monday, August 17th 2015, 9:46:54 am

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-1131

@eclipse-faces-bot
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant