Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage SE 8 Repeatable Annotations #1430

Closed
eclipse-faces-bot opened this issue Sep 16, 2016 · 6 comments
Closed

Leverage SE 8 Repeatable Annotations #1430

eclipse-faces-bot opened this issue Sep 16, 2016 · 6 comments

Comments

@eclipse-faces-bot
Copy link

A quick grep of our annotations (excluding the now deprecated
ManagedBeans ones) reveals the following likely candidates:

public @interface ManagedProperty {
./src/main/java/javax/faces/annotation/ManagedProperty.java

public @interface ListenerFor {
./src/main/java/javax/faces/event/ListenerFor.java
public @interface ListenersFor {
./src/main/java/javax/faces/event/ListenersFor.java

public @interface ResourceDependencies {
./src/main/java/javax/faces/application/ResourceDependencies.java
public @interface ResourceDependency {
./src/main/java/javax/faces/application/ResourceDependency.java

Any reason we should not make these SE 8 repeatable compatible?

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Reported by @edburns

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
commit 32091021f4c831b6902a05f989832472f0cb6fd7
Author: Ed Burns edward.burns@oracle.com
Date: Wed Sep 28 14:14:24 2016 -0400

#1430 Second try

modified: jsf-api/src/main/java/javax/faces/application/ResourceDependency.java
modified: jsf-api/src/main/java/javax/faces/event/ListenerFor.java
modified: test/javaee8/ajax/src/main/java/com/sun/faces/test/javaee8/ajax/Spec1423ComponentAddedProgrammatically.java

  • Tested that this did not break the build locally.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
@edburns said:
Build verified clean.

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
Marked as fixed on Tuesday, October 4th 2016, 1:16:19 pm

@eclipse-faces-bot
Copy link
Author

@glassfishrobot Commented
This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-1430

@eclipse-faces-bot
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant