JSF 2.3 Spec Section 5.9.1 and the javadocs contradict each other

[pnicolucci]

I originally opened this here: eclipse-ee4j/mojarra#4389

Creating this issue as a marker so we don't forget about this work.

1. The JSF 2.3 specification in Section 5.9.1 states the following:
   Support for Injection into JSF Managed Objects
   It must be possible to use @Inject when specifying the following kinds of JSF managed objects.
   ? Validators declared with @javax.faces.validator.FacesValidator(managed=”true”)
   ? Converters declared with @javax.faces.convert.FacesConverter(managed=”true”)
   ? FacesBehaviors declared with @javax.faces.component.behavior.FacesBehavior(managed=
   ”true”)

2. FacesConverter is defined in the following: FacesConverter this lists the following target: @target(value={TYPE,FIELD,METHOD,PARAMETER})

3. FacesValidator is defined in the following: FacesValidator this lists the following target: @target(value=TYPE)

4. FacesBehavior is defined in the following: FacesBehavior this lists the following target: @target(value=TYPE)

The FacesValidator and FacesBehavior should have updated targets to match FacesConverter and therefore be consistent with Section 5.9.1 of the JSF specification.

[arjantijms]

I agree, we can address that for the next (minor) spec version after Jakarta EE 8.

[scottmarlow]

Should #1471 be addressed post EE 9.1?

[arjantijms]

Yes, we're now preparing for 4.0 and have done an amount of work for it. Still have to draft the official plan, but this one can certainly be part of that. Faces 4.0 was, for now, not specifically planned for 9.1.

[pnicolucci]

Working to fix this here: Issue 4389

[pnicolucci]

I think we'll also want to add this to the changelog of the specification for Faces 4.0

[pnicolucci]

We likely also need to work with the TCK team to update the signature tests.

[scottmarlow]

We likely also need to work with the TCK team to update the signature tests.

FYI, the Platform TCK is currently using the https://github.com/jtulach/netbeans-apitest fork of the signature test tooling. We switched to use that for Jakarta EE 9.1 in order to support running the Platform TCK on Java SE 11+ versions (including Java SE 17).

[pnicolucci]

@arjantijms is there a plan to add a changelog to the specification for Faces 3.0 -> Faces 4.0? I didn't see one at first look. Just looking to see what else we need to do to get this one closed out for 4.0 now that it is implemented.

[arjantijms]

@pnicolucci The spec doc hasn't been updated yet, but yes, we should soon do that. @BalusC has been working on a "what's new in Faces 4.0", which we could probably use for the changelog (pick a summary from each section).

A @BalusC, how far are you with the what's new?

[BalusC]

It was already posted 2d ago: https://balusc.omnifaces.org/2021/11/whats-new-in-faces-40.html

[brideck]

We likely also need to work with the TCK team to update the signature tests.

My understanding is that this will automatically be handled later in the TCK development process when we run our tooling to generate fresh signatures from all of the new APIs in EE 10.

[pnicolucci]

@arjantijms are you ok with closing this issue now? Seems as though we'll have another PR to update the change history for the entire release at some point.

[arjantijms]

Sure, let's close it now. Thanks!

[scottmarlow]

We likely also need to work with the TCK team to update the signature tests.

My understanding is that this will automatically be handled later in the TCK development process when we run our tooling to generate fresh signatures from all of the new APIs in EE 10.

The Platform TCK signatures Faces signature file was generated with the Faces 4.0.0-M2 staged artifact. The job artifact link is jakarta.faces.sig_4.0_se11. I will attach the updated signature file here as well as jakarta.faces.sig_4.0_se11.txt.

@brideck @pnicolucci Please do confirm that the jakarta.faces.sig_4.0_se11.txt file does match the Faces javadocs for 4.0.

[brideck]

Excellent. Thanks for the ping, Scott. It looks to me like both of the expected updates are present in the new signature file.