Deprecate "targets" concept

[eclipse-faces-bot]

The "targets" attribute, present on several elements in the cc:interface section, is a blemish on the
purity of the interface declaration. It introduces a touch of implementation detail to the cc:interface
section. The "targets" attribute conceptually pushes information from the interface into the
implementation.

A less architecturally offensive solution is to make it so the implementation pulls this information from
the interface section.

Environment

Operating System: All
Platform: All

Affected Versions

[2.0]

[eclipse-faces-bot]

@glassfishrobot Commented
Reported by @edburns

[eclipse-faces-bot]

@glassfishrobot Commented
Sub-Tasks:
JAVASERVERFACES_SPEC_PUBLIC-755

[eclipse-faces-bot]

@glassfishrobot Commented
Issue-Links:
is related to
JAVASERVERFACES_SPEC_PUBLIC-755
is related to
JAVASERVERFACES-3121

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
Target 2.2

[eclipse-faces-bot]

@glassfishrobot Commented
jakobkorherr said:
Created an attachment (id=333)
Prototype for implementsActionSource,... including systest for actionSource and editableValueHolder

[eclipse-faces-bot]

@glassfishrobot Commented
File: jsf-spec-901-prototype-including-systest.patch
Attached By: jakobkorherr

[eclipse-faces-bot]

@glassfishrobot Commented
jakobkorherr said:
I added a prototype-patch for this issue that adds the following tags:

• cc:implementsActionSource
• cc:implementsEditableValueHolder
• cc:implementsValueHolder
• cc:insertClientBehavior

In addition, the patch contains a systest for cc:implementsActionSource and
cc:implementsEditableValueHolder.

Everything works great and it really felt good writing the tests with these new
tags.

One thing did not work though: f:ajax. It seems that it has some hack for
composite components which uses the targets attribute of cc:clientBehavior. Did
not jump into deep here, but "normal" client behaviors are working.

Frankly, I would really like to see some of this in JSF 2.1. If necessary, I can
provide more systests.

[eclipse-faces-bot]

@glassfishrobot Commented
kellerapps said:
Without targets=, how does one route composite component attrs like ValueChangeListener & validators to an impl component?

[eclipse-faces-bot]

@glassfishrobot Commented
jakobkorherr said:
via special tags as children of the target component(s). just see the above post..

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
LU> To be more explicit, this is the example that should fail:

LU> <ez:loginPanel id="loginPanel" model="#

{bean}

">
LU> <f:actionListener for="loginEvent"
LU> binding="#

{bean.loginEventListener}

" />
LU> <f:actionListener for="loginEvent"
LU> binding="#

{bean.loginEventListener2}

" />
LU> <f:actionListener for="cancelEvent"
LU> binding="#

{bean.cancelEventListener}

" />
LU> </ez:loginPanel>

LU> <composite:interface name="loginPanel">
LU> <composite:actionSource name="loginEvent" />
LU> <composite:actionSource name="cancelEvent" />
LU> </composite:interface>
LU> composite:implementation
LU> <h:commandButton name="button1">
LU> <f:actionListener
LU> binding="#

{cc.actionSource.loginEvent}

"/>
LU> </h:commandButton>
LU> <x:mycompositecomponent name="button2">
LU> <f:actionListener
LU> binding="#

{cc.actionSource.cancelEvent}

" for="someOtherEvent"/>
LU> </x:mycompositecomponent>
LU> </composite:implementation>

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:

• testcase war showing that this mostly works. The only part that
  doesn't work is the passing through of the listener to the inner cc,
  that's issue <http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-755>.

[eclipse-faces-bot]

@glassfishrobot Commented
File: i_spec_901.patch
Attached By: @edburns

[eclipse-faces-bot]

@glassfishrobot Commented
File: JAVASERVERFACES_SPEC_PUBLIC-901.zip
Attached By: @edburns

[eclipse-faces-bot]

@glassfishrobot Commented
@edburns said:
Due to lack of reply to my message about this issue on 2 June 2011 <http://java.net/projects/javaserverfaces-spec-public/lists/jsr344-experts/archive/2011-06/message/1> I am closing this issue and stating that the only real problem is #755.

[eclipse-faces-bot]

@glassfishrobot Commented
Marked as won't fix on Thursday, July 21st 2011, 3:09:06 pm

[eclipse-faces-bot]

@glassfishrobot Commented
@manfredriem said:
Closing resolved issue out

[eclipse-faces-bot]

@glassfishrobot Commented
This issue was imported from java.net JIRA JAVASERVERFACES_SPEC_PUBLIC-901

[eclipse-faces-bot]

• Issue Imported From: Deprecate "targets" concept javaee/javaserverfaces-spec#901
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @edburns
• Original Issue Closed By:@glassfishrobot