Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change maven coordinates to be org.glassfish.concurro:concurro #67

Closed
arjantijms opened this issue Feb 8, 2024 · 4 comments · Fixed by #81
Closed

Change maven coordinates to be org.glassfish.concurro:concurro #67

arjantijms opened this issue Feb 8, 2024 · 4 comments · Fixed by #81

Comments

@arjantijms
Copy link
Contributor

We currently have org.glassfish:jakarta.enterprise.concurrent as maven coordinates. To be consistent with other projects I think this should become org.glassfish.concurro:concurro.

e.g.

  • org.glassfish.hk2:hk2
  • org.glassfish.exousia:exousia
  • org.glassfish.wasp:wasp

Thoughts?

@OndroMih @aubi @avpinchuk @dmatej

@dmatej
Copy link
Contributor

dmatej commented Feb 8, 2024

I agree. In the future there might be some submodules, so this is a good pattern.

@avpinchuk
Copy link

+1.

In my opinion, this looks reasonable.

@aubi
Copy link
Contributor

aubi commented Feb 15, 2024

I just added my last PR regarding virtual threads, so I don't have anything in progress. If nobody else has, it's good time to do this change.
Do you want to change package name as well?

@arjantijms
Copy link
Contributor Author

Do you want to change package name as well?

Yes, that should be a good change to do as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants