Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1.0-RC1 release is missing some embedded packages #22616

Closed
candrews opened this issue Nov 19, 2018 · 8 comments
Closed

5.1.0-RC1 release is missing some embedded packages #22616

candrews opened this issue Nov 19, 2018 · 8 comments

Comments

@candrews
Copy link
Contributor

I see that 5.1.0-RC1 was released, here's the main zip: https://repo1.maven.org/maven2/org/glassfish/main/distributions/glassfish/5.1.0-RC1/glassfish-5.1.0-RC1.zip

Some component packages of Glassfish were updated for this release, while others were not. For example, https://repo1.maven.org/maven2/org/glassfish/main/extras/glassfish-embedded-shell-frag/ was updated was updated.

These packages I'd expect to be updated were not:

Can you please update all of these (and any I've missed)?

IMHO, this is a blocking issue for #22606

@romain-grecourt
Copy link
Member

We will fix these for the next RC build.

@candrews
Copy link
Contributor Author

#22604 says that Glassfish 5.1 (final release already?) has been released to the OSSRH staging repository and it does not have this issue fixed.
https://oss.sonatype.org/content/groups/staging/org/glassfish/main/extras/ is missing glassfish-embedded-web, glassfish-embedded-all, and embedded

@romain-grecourt
Copy link
Member

@vinayvishal can you comment on that ?

@vinayvishal
Copy link
Contributor

@romain-grecourt , If you remember, embedded profile was disabled since the beginning. That is why these artefacts are not there. Do we want to enable embedded profile too? I am not sure why it was disabled in first place.

@candrews
Copy link
Contributor Author

candrews commented Dec 9, 2018

Any news on this? IMHO, it's important that the next Glassfish release include the same embedded support that prior releases have.

@romain-grecourt
Copy link
Member

@vinayvishal Yes, we do want to enable the embedded profiles. Let me know if you run into issues.

@vinayvishal
Copy link
Contributor

@vinayvishal Yes, we do want to enable the embedded profiles. Let me know if you run into issues.

@romain-grecourt , sure, I will do it soon and publish the updated artefacts to staging repository.

@candrews
Copy link
Contributor Author

5.1.0-RC2 publishes these artifacts resolving this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants