Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing sources and javadoc Maven artifacts for 7.0.0 #24278

Open
OndroMih opened this issue Jan 28, 2023 · 5 comments
Open

Missing sources and javadoc Maven artifacts for 7.0.0 #24278

OndroMih opened this issue Jan 28, 2023 · 5 comments

Comments

@OndroMih
Copy link
Contributor

The GlassFish artifacts in Maven Central either don't contain sources and javadoc artifacts or they contain them, but without any relevant content.

GlassFish Full 7.0.0: https://repo1.maven.org/maven2/org/glassfish/main/distributions/glassfish/7.0.0/

  • contains sources JAR, but it's empty, no sources there
  • javadoc JAR is missing

GlassFish Web 7.0.0: https://repo1.maven.org/maven2/org/glassfish/main/distributions/web/7.0.0/

  • same as Full - sources JAR is empty, no javadoc JAR

GlassFish Embedded All: https://repo1.maven.org/maven2/org/glassfish/main/extras/glassfish-embedded-all/7.0.0/

  • contains sources and javadoc JARs, but both are empty

GlassFish Embedded Web: https://repo1.maven.org/maven2/org/glassfish/main/extras/glassfish-embedded-web/7.0.0/

  • same as Embedded All, contains sources and javadoc JARs, but both are empty

This means that no Javadoc is available at javadoc.io, e.g. https://javadoc.io/doc/org.glassfish.main.extras/glassfish-embedded-all
Also, no sources can be downloaded by IDEs from Maven.

@dmatej
Copy link
Contributor

dmatej commented Jan 28, 2023

In Eclipse it works well, because it can see pom.xml and links dependencies.
But sure, we can still download and unpack sources of all dependencies and repack them again. I hope I will not see everything twice then :-D

@OndroMih
Copy link
Contributor Author

In Eclipse it works well, because it can see pom.xml and links dependencies. But sure, we can still download and unpack sources of all dependencies and repack them again. I hope I will not see everything twice then :-D

Maybe it works in other IDEs too, I'm not too concerned about sources. But I'd like to fix the javadoc JAR so that it's possible to see javadoc at javadoc.io, and then we could also link to javadocs there from the glassfish.org site.

@dmatej
Copy link
Contributor

dmatej commented Jan 28, 2023

I am sure that we should not distribute empty jar files - they shouldn't be distributed at all OR they should contain the same as the binary (I mean sources).

Copy link

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

@github-actions github-actions bot added the Stale label Jan 29, 2024
@OndroMih
Copy link
Contributor Author

This is still relevant and hasn't been addressed.

@dmatej dmatej removed the Stale label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants