Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean code: Fix "Unlikely argument type for equals()" and remove some unused variables #24868

Closed
escay opened this issue Mar 21, 2024 · 1 comment
Milestone

Comments

@escay
Copy link
Contributor

escay commented Mar 21, 2024

Fix some of the warnings Eclipse IDE shows me

These items are probably bugs:

## Unlikely argument type SimpleJndiName for remove(Object) on a Map<String,NamingObjectProxy>	ManagedBeanManagerImpl.java	/container-common/src/main/java/com/sun/enterprise/container/common/impl/managedbean	line 338	Java Problem
## Unlikely argument type for equals(): SimpleJndiName seems to be unrelated to String	JdbcConnPoolAppStatsProvider.java	/jdbc-runtime/src/main/java/org/glassfish/jdbc/pool/monitor	line 90	Java Problem
## Unlikely argument type for equals(): SimpleJndiName seems to be unrelated to String	JdbcConnPoolAppStatsProvider.java	/jdbc-runtime/src/main/java/org/glassfish/jdbc/pool/monitor	line 109	Java Problem
## Unlikely argument type for equals(): SimpleJndiName seems to be unrelated to String	JdbcConnPoolAppStatsProvider.java	/jdbc-runtime/src/main/java/org/glassfish/jdbc/pool/monitor	line 124	Java Problem
## Unlikely argument type for equals(): SimpleJndiName seems to be unrelated to String	JdbcConnPoolAppStatsProvider.java	/jdbc-runtime/src/main/java/org/glassfish/jdbc/pool/monitor	line 136	Java Problem

List of fixes:

Description	Resource	Path	Location	Type

finally block does not complete normally	HTTPInputArchive.java	/gf-client-module/src/main/java/org/glassfish/appclient/client/acc	line 131	Java Problem

The value of the field AbstractBundleNode<T>.W3C_XML_SCHEMA is not used	AbstractBundleNode.java	/dol/src/main/java/com/sun/enterprise/deployment/node	line 46	Java Problem
The value of the field AbstractStaxProvider<T>.ANY_XML_MEDIATYPE is not used	AbstractStaxProvider.java	/rest-service/src/main/java/org/glassfish/admin/rest/provider	line 48	Java Problem
The value of the field AMXProxyHandler.EMPTY_SIG is not used	AMXProxyHandler.java	/amx-core/src/main/java/org/glassfish/admin/amx/core/proxy	line 155	Java Problem
The value of the field AMXProxyHandler.EMPTY_String_AMX is not used	AMXProxyHandler.java	/amx-core/src/main/java/org/glassfish/admin/amx/core/proxy	line 275	Java Problem
The value of the field AMXProxyHandler.METHOD_CHILDREN is not used	AMXProxyHandler.java	/amx-core/src/main/java/org/glassfish/admin/amx/core/proxy	line 293	Java Problem
The value of the field AMXValidator.mValidationLevel is not used	AMXValidator.java	/amx-core/src/main/java/org/glassfish/admin/amx/core	line 151	Java Problem
The value of the field AppClientDeployer.logger is not used	AppClientDeployer.java	/appclient-server-core/src/main/java/org/glassfish/appclient/server/core	line 123	Java Problem
The value of the field AppClientHTTPAdapter.IF_UNMODIFIED_SINCE is not used	AppClientHTTPAdapter.java	/appclient-server-core/src/main/java/org/glassfish/appclient/server/core/jws	line 58	Java Problem
The value of the field ApplicationConfigListener.localStrings is not used	ApplicationConfigListener.java	/kernel/src/main/java/com/sun/enterprise/v3/server	line 59	Java Problem
The value of the field AuthenticationServiceImpl.LOG is not used	AuthenticationServiceImpl.java	/security-services/src/main/java/org/glassfish/security/services/impl	line 79	Java Problem
The value of the field AutoDeployDirectoryScanner.localStrings is not used	AutoDeployDirectoryScanner.java	/deployment-autodeploy/src/main/java/org/glassfish/deployment/autodeploy	line 52	Java Problem
The value of the field AutoPersistentNew.messages is not used	AutoPersistentNew.java	/cmp-support-sqlstore/src/main/java/com/sun/jdo/spi/persistence/support/sqlstore/state	line 32	Java Problem
The value of the field AppServerStartupTest.TestStartupService.dependency is not used	AppServerStartupTest.java	/kernel/src/test/java/com/sun/enterprise/v3/server	line 496	Java Problem
The value of the field BatchRuntimeHelper.CREATE_TABLE_DDL_NAME is not used	BatchRuntimeHelper.java	/glassfish-batch-connector/src/main/java/org/glassfish/batch/spi/impl	line 93	Java Problem
The value of the field BeanAroundInvokeInterceptor.NULL_ARGS is not used	InterceptorManager.java	/ejb-container/src/main/java/com/sun/ejb/containers/interceptors	line 788	Java Problem
The value of the field BootAMX.JMX_LOGGER is not used	BootAMX.java	/glassfish-mbeanserver/src/main/java/org/glassfish/admin/mbeanserver	line 38	Java Problem
The value of the field XMLTest.LocalEntityResolver.SYSTEM_ID_PREFIX is not used	XMLTest.java	/acc-config/src/test/java/org/glassfish/appclient/client/acc/config/util	line 140	Java Problem
The value of the field UpgradeService.MODULE_TYPE is not used	UpgradeService.java	/admin-core/src/main/java/com/sun/enterprise/admin	line 64	Java Problem
The value of the field ClusterITest.TEST_WAR_FILENAME is not used	ClusterITest.java	/admin-tests/src/test/java/org/glassfish/main/admin/test	line 65	Java Problem
The value of the field ClusterITest.TEST_WAR_LOCATION is not used	ClusterITest.java	/admin-tests/src/test/java/org/glassfish/main/admin/test	line 66	Java Problem
The value of the field CommandProgressImpl.eTag is not used	CommandProgressImpl.java	/admin-util/src/main/java/com/sun/enterprise/admin/progress	line 90	Java Problem
The value of the field RemoteResponseManager.m is not used	RemoteResponseManager.java	/admin-util/src/main/java/com/sun/enterprise/admin/remote	line 53	Java Problem
The value of the field RemoteRestAdminCommand.QUERY_STRING_SEPARATOR is not used	RemoteRestAdminCommand.java	/admin-util/src/main/java/com/sun/enterprise/admin/remote	line 113	Java Problem
The value of the field CommandSecurityChecker.RESOURCE_NAME_URL_ENCODING is not used	CommandSecurityChecker.java	/admin-util/src/main/java/com/sun/enterprise/admin/util	line 73	Java Problem
The value of the field GenericAdminAuthenticator.lsm is not used	GenericAdminAuthenticator.java	/admin-util/src/main/java/com/sun/enterprise/admin/util	line 126	Java Problem
The value of the field TokenizerImpl.QUOTE_CHAR is not used	TokenizerImpl.java	/admin-util/src/main/java/com/sun/enterprise/admin/util	line 54	Java Problem
The value of the field TokenizerInternal.TAB_CHAR is not used	TokenizerImpl.java	/admin-util/src/main/java/com/sun/enterprise/admin/util	line 203	Java Problem
The value of the field PathnameParser.NAME_SEARCH_PATTERN is not used	PathnameParser.java	/amx-core/src/main/java/org/glassfish/admin/amx/core	line 202	Java Problem
The value of the local variable children is not used	AMXValidator.java	/amx-core/src/main/java/org/glassfish/admin/amx/core	line 537	Java Problem
The value of the local variable name is not used	AMXValidator.java	/amx-core/src/main/java/org/glassfish/admin/amx/core	line 520	Java Problem
The value of the local variable parent is not used	AMXValidator.java	/amx-core/src/main/java/org/glassfish/admin/amx/core	line 529	Java Problem
The value of the field ProxyFactory.DOMAIN_ROOT_KEY is not used	ProxyFactory.java	/amx-core/src/main/java/org/glassfish/admin/amx/core/proxy	line 172	Java Problem
The value of the local variable isRemotable is not used	ConfigBeanJMXSupport.java	/amx-core/src/main/java/org/glassfish/admin/amx/impl/config	line 479	Java Problem
The value of the field RealmsImpl.ANONYMOUS_USER is not used	RealmsImpl.java	/amx-core/src/main/java/org/glassfish/admin/amx/impl/mbean	line 348	Java Problem
The value of the field ToolsImpl.NL is not used	ToolsImpl.java	/amx-core/src/main/java/org/glassfish/admin/amx/impl/mbean	line 40	Java Problem
The value of the local variable failure is not used	AMXImplBase.java	/amx-core/src/main/java/org/glassfish/admin/amx/impl/mbean	line 545	Java Problem
The value of the local variable handleManually is not used	AMXImplBase.java	/amx-core/src/main/java/org/glassfish/admin/amx/impl/mbean	line 353	Java Problem
The value of the local variable handleManually is not used	AMXImplBase.java	/amx-core/src/main/java/org/glassfish/admin/amx/impl/mbean	line 572	Java Problem
The value of the local variable supports is not used	SystemInfoImpl.java	/amx-core/src/main/java/org/glassfish/admin/amx/impl/mbean	line 75	Java Problem
The value of the local variable unimplemented is not used	AMXImplBase.java	/amx-core/src/main/java/org/glassfish/admin/amx/impl/mbean	line 780	Java Problem
The value of the field ObjectNameBuilder.EMPTY_STRING_ARRAY is not used	ObjectNameBuilder.java	/amx-core/src/main/java/org/glassfish/admin/amx/impl/util	line 59	Java Problem
The value of the local variable start is not used	FeatureAvailability.java	/amx-core/src/main/java/org/glassfish/admin/amx/util	line 226	Java Problem
The value of the field MBeanOperationInfoComparator.OPERATION_INFO_STRINGIFIER is not used	MBeanOperationInfoComparator.java	/amx-core/src/main/java/org/glassfish/admin/amx/util/jmx	line 30	Java Problem
The value of the field MBeanProxyHandler.LOG_LEVEL_NAME is not used	MBeanProxyHandler.java	/amx-core/src/main/java/org/glassfish/admin/amx/util/jmx	line 287	Java Problem
The value of the field NotificationEmitterSupport.NO_TYPES is not used	NotificationEmitterSupport.java	/amx-core/src/main/java/org/glassfish/admin/amx/util/jmx	line 124	Java Problem
The value of the field OpenMBeanUtil.EMPTY_OPENTYPES is not used	OpenMBeanUtil.java	/amx-core/src/main/java/org/glassfish/admin/amx/util/jmx	line 96	Java Problem
The value of the field OpenMBeanUtil.EMPTY_STRING_ARRAY is not used	OpenMBeanUtil.java	/amx-core/src/main/java/org/glassfish/admin/amx/util/jmx	line 94	Java Problem
The value of the local variable attrName is not used	JMXUtil.java	/amx-core/src/main/java/org/glassfish/admin/amx/util/jmx	line 1029	Java Problem
The value of the local variable instance is not used	AMXJ2EEStartupService.java	/amx-jakartaee/src/main/java/org/glassfish/admin/amx/impl/j2ee/loader	line 138	Java Problem
The value of the field JavaWebStartInfo.GLASSFISH_DIRECTORY_PREFIX is not used	JavaWebStartInfo.java	/appclient-server-core/src/main/java/org/glassfish/appclient/server/core/jws	line 84	Java Problem
The value of the field JavaWebStartInfo.localStrings is not used	JavaWebStartInfo.java	/appclient-server-core/src/main/java/org/glassfish/appclient/server/core/jws	line 191	Java Problem
The value of the field ServletTest.context is not used	ServletTest.java	/applicationDispatcher/src/main/java/test	line 25	Java Problem
The value of the local variable backupDir is not used	BackupRestoreManager.java	/backup/src/main/java/com/sun/enterprise/backup	line 78	Java Problem
The value of the local variable t is not used	TimerEjb.java	/basic/src/main/java/org/glassfish/tests/embedded/ejb/basic	line 36	Java Problem
The value of the local variable host is not used	NodeAgentConfigUpgrade.java	/cluster-admin/src/main/java/com/sun/enterprise/v3/admin/cluster	line 81	Java Problem
The value of the field CreateLocalInstanceCommand.strings is not used	CreateLocalInstanceCommand.java	/cluster-cli/src/main/java/com/sun/enterprise/admin/cli/cluster	line 59	Java Problem
The value of the field NodeRunnerSsh.NL is not used	NodeRunnerSsh.java	/cluster-ssh/src/main/java/org/glassfish/cluster/ssh/connect	line 38	Java Problem
The value of the local variable mfe is not used	MappingFile.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb	line 547	Java Problem
The value of the local variable pfe is not used	MappingFile.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb	line 623	Java Problem
The value of the local variable n is not used	CheckVersionOfAccessedInstances.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 115	Java Problem
The value of the local variable s is not used	CheckVersionOfAccessedInstances.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 113	Java Problem
The value of the local variable restrictionFailure is not used	CheckVersionOfAccessedInstances.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 103	Java Problem
The value of the local variable restrictionPassed is not used	CheckVersionOfAccessedInstances.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 104	Java Problem
The value of the local variable n is not used	ColumnPair.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 115	Java Problem
The value of the local variable restrictionFailure is not used	ColumnPair.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 103	Java Problem
The value of the local variable restrictionPassed is not used	ColumnPair.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 104	Java Problem
The value of the local variable s is not used	ColumnPair.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 113	Java Problem
The value of the local variable n is not used	FetchedWith.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 213	Java Problem
The value of the local variable restrictionFailure is not used	FetchedWith.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 154	Java Problem
The value of the local variable restrictionPassed is not used	FetchedWith.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 155	Java Problem
The value of the local variable o is not used	Consistency.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 418	Java Problem
The value of the local variable restrictionFailure is not used	Consistency.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 257	Java Problem
The value of the local variable restrictionPassed is not used	Consistency.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 258	Java Problem
The value of the local variable s is not used	Consistency.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 417	Java Problem
The value of the local variable o is not used	SunCmpMappings.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 308	Java Problem
The value of the local variable restrictionFailure is not used	SunCmpMapping.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 126	Java Problem
The value of the local variable restrictionFailure is not used	SunCmpMappings.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 249	Java Problem
The value of the local variable restrictionPassed is not used	SunCmpMapping.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 127	Java Problem
The value of the local variable restrictionPassed is not used	SunCmpMappings.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 250	Java Problem
The value of the local variable s is not used	SunCmpMapping.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 146	Java Problem
The value of the local variable s is not used	SunCmpMappings.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 307	Java Problem
The value of the local variable restrictionFailure is not used	CmpFieldMapping.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 160	Java Problem
The value of the local variable restrictionPassed is not used	CmpFieldMapping.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 161	Java Problem
The value of the local variable s is not used	CmpFieldMapping.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 179	Java Problem
The value of the local variable restrictionFailure is not used	CmrFieldMapping.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 150	Java Problem
The value of the local variable restrictionPassed is not used	CmrFieldMapping.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 151	Java Problem
The value of the local variable s is not used	CmrFieldMapping.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 174	Java Problem
The value of the local variable restrictionFailure is not used	EntityMapping.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 268	Java Problem
The value of the local variable restrictionPassed is not used	EntityMapping.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 269	Java Problem
The value of the local variable s is not used	EntityMapping.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 310	Java Problem
The value of the local variable restrictionFailure is not used	SecondaryTable.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 126	Java Problem
The value of the local variable restrictionPassed is not used	SecondaryTable.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 127	Java Problem
The value of the local variable s is not used	SecondaryTable.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb/beans	line 146	Java Problem
The value of the local variable in is not used	Main.java	/cmp-enhancer/src/main/java/com/sun/jdo/api/persistence/enhancer	line 625	Java Problem
The value of the local variable n is not used	Main.java	/cmp-enhancer/src/main/java/com/sun/jdo/api/persistence/enhancer	line 622	Java Problem
The value of the local variable os is not used	ClassFile.java	/cmp-enhancer/src/main/java/com/sun/jdo/api/persistence/enhancer/classfile	line 387	Java Problem
The value of the field DatabaseOutputStream.messages is not used	DatabaseOutputStream.java	/cmp-generator-database/src/main/java/com/sun/jdo/spi/persistence/generator/database	line 44	Java Problem
The value of the local variable mappingField is not used	DatabaseGenerator.java	/cmp-generator-database/src/main/java/com/sun/jdo/spi/persistence/generator/database	line 299	Java Problem
The value of the local variable schemaName is not used	DDLGenerator.java	/cmp-generator-database/src/main/java/com/sun/jdo/spi/persistence/generator/database	line 113	Java Problem
The value of the local variable model is not used	ModelValidator.java	/cmp-model/src/main/java/com/sun/jdo/api/persistence/model/util	line 2195	Java Problem
The value of the local variable repr is not used	DumpMapping.java	/cmp-model/src/main/java/com/sun/jdo/api/persistence/model/util	line 305	Java Problem
The value of the local variable repr is not used	DumpMapping.java	/cmp-model/src/main/java/com/sun/jdo/api/persistence/model/util	line 321	Java Problem
The value of the local variable debug is not used	JDOEJB20HelperImpl.java	/cmp-support-ejb/src/main/java/com/sun/jdo/spi/persistence/support/ejb/cmp	line 125	Java Problem
The value of the local variable debug is not used	JDOEJB20HelperImpl.java	/cmp-support-ejb/src/main/java/com/sun/jdo/spi/persistence/support/ejb/cmp	line 149	Java Problem
The value of the local variable debug is not used	JDOEJB20HelperImpl.java	/cmp-support-ejb/src/main/java/com/sun/jdo/spi/persistence/support/ejb/cmp	line 177	Java Problem
The value of the local variable collParamTypes is not used	JDOConcreteBeanGenerator.java	/cmp-support-ejb/src/main/java/com/sun/jdo/spi/persistence/support/ejb/ejbc	line 1144	Java Problem
The value of the local variable t is not used	ConnectionManager.java	/cmp-support-sqlstore/src/main/java/com/sun/jdo/spi/persistence/support/sqlstore/connection	line 2170	Java Problem
The value of the field CMPHelper.logger is not used	CMPHelper.java	/cmp-support-sqlstore/src/main/java/com/sun/jdo/spi/persistence/support/sqlstore/ejb	line 54	Java Problem
The value of the field EJBHelper.logger is not used	EJBHelper.java	/cmp-support-sqlstore/src/main/java/com/sun/jdo/spi/persistence/support/sqlstore/ejb	line 46	Java Problem
The value of the local variable i is not used	TransactionImpl.java	/cmp-support-sqlstore/src/main/java/com/sun/jdo/spi/persistence/support/sqlstore/impl	line 1523	Java Problem
The value of the local variable o is not used	TransactionImpl.java	/cmp-support-sqlstore/src/main/java/com/sun/jdo/spi/persistence/support/sqlstore/impl	line 1524	Java Problem
The value of the field Hollow.messages is not used	Hollow.java	/cmp-support-sqlstore/src/main/java/com/sun/jdo/spi/persistence/support/sqlstore/state	line 33	Java Problem
The value of the field PersistentClean.messages is not used	PersistentClean.java	/cmp-support-sqlstore/src/main/java/com/sun/jdo/spi/persistence/support/sqlstore/state	line 32	Java Problem
The value of the field PersistentNew.messages is not used	PersistentNew.java	/cmp-support-sqlstore/src/main/java/com/sun/jdo/spi/persistence/support/sqlstore/state	line 32	Java Problem
The value of the field PersistentNonTransactional.messages is not used	PersistentNonTransactional.java	/cmp-support-sqlstore/src/main/java/com/sun/jdo/spi/persistence/support/sqlstore/state	line 32	Java Problem
The value of the field NullSemaphore.messages is not used	NullSemaphore.java	/cmp-utility/src/main/java/com/sun/jdo/spi/persistence/utility	line 42	Java Problem
The value of the local variable file is not used	AbstractLogger.java	/cmp-utility/src/main/java/com/sun/jdo/spi/persistence/utility/logging	line 134	Java Problem
The value of the local variable logger is not used	LogHelper.java	/cmp-utility/src/main/java/com/sun/jdo/spi/persistence/utility/logging	line 81	Java Problem
The value of the local variable f is not used	FileUtilsTest.java	/common-util/src/test/java/com/sun/enterprise/util/io	line 49	Java Problem
The value of the local variable length is not used	FileLockTest.java	/common-util/src/test/java/org/glassfish/common/util/admin/locking	line 273	Java Problem
The value of the field JDBCRealmPropertyCheckValidator.DEFAULT_DIGEST_ALGORITHM is not used	JDBCRealmPropertyCheckValidator.java	/config-api/src/main/java/com/sun/enterprise/config/serverbeans/customvalidators	line 33	Java Problem
The value of the field DomainXml.strings is not used	DomainXml.java	/config-api/src/main/java/org/glassfish/config/support	line 303	Java Problem
The value of the field ConnectorSecurityMap.localStrings is not used	ConnectorSecurityMap.java	/connectors-admin/src/main/java/org/glassfish/connectors/admin/cli	line 36	Java Problem
The value of the field ManagedConnectionFactory.debug is not used	ManagedConnectionFactory.java	/connectors-ra-redeploy-jars/src/main/java/com/sun/jdbcra/spi	line 53	Java Problem
The value of the field ManagedConnectionMetaData.debug is not used	ManagedConnectionMetaData.java	/connectors-ra-redeploy-jars/src/main/java/com/sun/jdbcra/spi	line 42	Java Problem
The value of the local variable dmd is not used	ManagedConnectionFactory.java	/connectors-ra-redeploy-jars/src/main/java/com/sun/jdbcra/spi	line 314	Java Problem
The value of the local variable e is not used	LocalTransaction.java	/connectors-ra-redeploy-jars/src/main/java/com/sun/jdbcra/spi	line 69	Java Problem
The value of the local variable rs is not used	ManagedConnectionFactory.java	/connectors-ra-redeploy-jars/src/main/java/com/sun/jdbcra/spi	line 339	Java Problem
The value of the field MethodExecutor.debug is not used	MethodExecutor.java	/connectors-ra-redeploy-jars/src/main/java/com/sun/jdbcra/util	line 40	Java Problem
The value of the field JMSDestinationDefinitionDeployer.LOG is not used	JMSDestinationDefinitionDeployer.java	/connectors-runtime/src/main/java/com/sun/enterprise/resource/deployer	line 55	Java Problem
The value of the field ConnectionLeakDetector.localStrings is not used	ConnectionLeakDetector.java	/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool	line 55	Java Problem
The value of the field PoolManagerImpl.MESSAGES is not used	PoolManagerImpl.java	/connectors-runtime/src/main/java/com/sun/enterprise/resource/pool	line 80	Java Problem
The value of the local variable id is not used	GadgetHandlers.java	/console-common/src/main/java/org/glassfish/admingui/common/gadget	line 102	Java Problem
The value of the local variable chStr is not used	UtilHandlers.java	/console-common/src/main/java/org/glassfish/admingui/common/handlers	line 1059	Java Problem
The value of the local variable len is not used	UtilHandlers.java	/console-common/src/main/java/org/glassfish/admingui/common/handlers	line 1060	Java Problem
The value of the local variable listItem is not used	CommonHandlers.java	/console-common/src/main/java/org/glassfish/admingui/common/handlers	line 224	Java Problem
The value of the local variable unknown is not used	ClusterHandler.java	/console-common/src/main/java/org/glassfish/admingui/common/handlers	line 81	Java Problem
The value of the local variable match is not used	JSONUtil.java	/console-common/src/main/java/org/glassfish/admingui/common/util	line 576	Java Problem
The value of the local variable title is not used	WoodstockHandler.java	/console-core/src/main/java/org/glassfish/admingui/handlers	line 446	Java Problem
The value of the field GetApplicationLaunchURLsCommand.localStrings is not used	GetApplicationLaunchURLsCommand.java	/deployment-admin/src/main/java/org/glassfish/deployment/admin	line 70	Java Problem
The value of the field GetDeploymentConfigurationsCommand.localStrings is not used	GetDeploymentConfigurationsCommand.java	/deployment-admin/src/main/java/org/glassfish/deployment/admin	line 67	Java Problem
The value of the field GetHostAndPortCommand.localStrings is not used	GetHostAndPortCommand.java	/deployment-admin/src/main/java/org/glassfish/deployment/admin	line 85	Java Problem
The value of the field InstanceDeployCommand.LS is not used	InstanceDeployCommand.java	/deployment-admin/src/main/java/org/glassfish/deployment/admin	line 87	Java Problem
The value of the field InstanceLifecycleModuleCommand.localStrings is not used	InstanceLifecycleModuleCommand.java	/deployment-admin/src/main/java/org/glassfish/deployment/admin	line 64	Java Problem
The value of the field IsSnifferUserVisibleCommand.localStrings is not used	IsSnifferUserVisibleCommand.java	/deployment-admin/src/main/java/org/glassfish/deployment/admin	line 51	Java Problem
The value of the field ListAppRefsCommand.localStrings is not used	ListAppRefsCommand.java	/deployment-admin/src/main/java/org/glassfish/deployment/admin	line 87	Java Problem
The value of the field ListLibrariesCommand.localStrings is not used	ListLibrariesCommand.java	/deployment-admin/src/main/java/org/glassfish/deployment/admin	line 56	Java Problem
The value of the field GetContextRootCommand.localStrings is not used	GetContextRootCommand.java	/deployment-jakartaee-core/src/main/java/org/glassfish/javaee/core/deployment	line 53	Java Problem
The value of the local variable oldSize is not used	FIFOEJBObjectCache.java	/entitybean-container/src/main/java/org/glassfish/persistence/ejb/entitybean/container/cache	line 207	Java Problem
The value of the local variable idleTimeoutInSeconds is not used	EntityContainer.java	/entitybean-container/src/main/java/org/glassfish/persistence/ejb/entitybean/container	line 446	Java Problem
The value of the local variable resizeQuantity is not used	EntityContainer.java	/entitybean-container/src/main/java/org/glassfish/persistence/ejb/entitybean/container	line 445	Java Problem
The value of the local variable steadyPoolSize is not used	EntityContainer.java	/entitybean-container/src/main/java/org/glassfish/persistence/ejb/entitybean/container	line 444	Java Problem
The value of the local variable exc is not used	EntityContainer.java	/entitybean-container/src/main/java/org/glassfish/persistence/ejb/entitybean/container	line 2425	Java Problem
The value of the local variable lru is not used	EntityContainer.java	/entitybean-container/src/main/java/org/glassfish/persistence/ejb/entitybean/container	line 2702	Java Problem
The value of the field ServletTest.context is not used	ServletTest.java	/dirListing/src/main/java/test	line 25	Java Problem
The value of the local variable cookies is not used	WebTest.java	/dirListing/src/test/java/org/glassfish/tests/dirListing	line 55	Java Problem
The value of the local variable index is not used	WebTest.java	/dirListing/src/test/java/org/glassfish/tests/dirListing	line 54	Java Problem
The value of the field ManagedScheduledExecutorDefinitionListHandler.LOG is not used	ManagedScheduledExecutorDefinitionListHandler.java	/dol/src/main/java/com/sun/enterprise/deployment/annotation/handlers	line 36	Java Problem
The value of the field EJBLocalObjectImpl._logger is not used	EJBLocalObjectImpl.java	/ejb-container/src/main/java/com/sun/ejb/containers	line 45	Java Problem
The value of the field EJBObjectImpl.localStrings is not used	EJBObjectImpl.java	/ejb-container/src/main/java/com/sun/ejb/containers	line 47	Java Problem
The value of the field StatefulSessionContainer.EEMRefInfo.hc is not used	StatefulSessionContainer.java	/ejb-container/src/main/java/com/sun/ejb/containers	line 3137	Java Problem

The import org.netbeans.modules.dbschema.util is never used	CaptureSchema.java	/cmp-ejb-mapping/src/main/java/com/sun/jdo/api/persistence/mapping/ejb	line 27	Java Problem

Resource leak: '<unassigned Closeable value>' is never closed	ExpandWar.java	/web-core/src/main/java/org/apache/catalina/startup	line 303	Java Problem
Resource leak: '<unassigned Closeable value>' is never closed	ExpandWar.java	/web-core/src/main/java/org/apache/catalina/startup	line 304	Java Problem
Resource leak: '<unassigned Closeable value>' is not closed at this location	JavaClientGenerator.java	/rest-service/src/main/java/org/glassfish/admin/rest/generator/client	line 157	Java Problem
Resource leak: '<unassigned Closeable value>' is not closed at this location	JavaClientGenerator.java	/rest-service/src/main/java/org/glassfish/admin/rest/generator/client	line 157	Java Problem
Resource leak: '<unassigned Closeable value>' is not closed at this location	PythonClientGenerator.java	/rest-service/src/main/java/org/glassfish/admin/rest/generator/client	line 107	Java Problem
Resource leak: 'input' is never closed	Main.java	/cmp-enhancer/src/main/java/com/sun/jdo/api/persistence/enhancer	line 563	Java Problem
Resource leak: 'jar' is never closed	ScatteredArchive.java	/internal-api/src/main/java/org/glassfish/internal/embedded	line 313	Java Problem
Resource leak: 'modulesJar' is never closed	Util.java	/bootstrap/src/main/java/org/glassfish/uberjar/bootstrap	line 101	Java Problem
Resource leak: 'raf' is never closed	RecoveryLockFile.java	/jts/src/main/java/com/sun/enterprise/transaction/jts/recovery	line 232	Java Problem
Resource leak: 'raf' is never closed	RecoveryLockFile.java	/jts/src/main/java/com/sun/enterprise/transaction/jts/recovery	line 301	Java Problem
Resource leak: 'raf' is never closed	RecoveryLockFile.java	/jts/src/main/java/com/sun/enterprise/transaction/jts/recovery	line 393	Java Problem
Resource leak: 'sftpClient' is never closed	SSHLauncher.java	/cluster-ssh/src/main/java/org/glassfish/cluster/ssh/launcher	line 469	Java Problem
Resource leak: 'webClient' is never closed	ServletMain.java	/servlet/src/test/java/org/glassfish/tests/embedded/web/servlet	line 70	Java Problem

The method put(String, Integer, EnumSet<PropagationMode>) is ambiguous for the type View	ContextImplUnitTest.java	/diagnostics-context/src/test/java/org/glassfish/diagnostics/context/impl	line 98	Java Problem
The method put(String, Integer, EnumSet<PropagationMode>) is ambiguous for the type View	ContextImplUnitTest.java	/diagnostics-context/src/test/java/org/glassfish/diagnostics/context/impl	line 99	Java Problem

Varargs methods should only override or be overridden by other varargs methods unlike EmptyVisitor.visitTableSwitchInsn(int, int, Label, Label[]) and MethodVisitor.visitTableSwitchInsn(int, int, Label, Label...)	EmptyVisitor.java	/admin-cli/src/main/java/com/sun/enterprise/admin/cli/schemadoc	line 102	Java Problem
Varargs methods should only override or be overridden by other varargs methods unlike LocalStringManagerImpl.getLocalString(Class, String, String, Object...) and LocalStringManager.getLocalString(Class, String, String, Object[])	LocalStringManagerImpl.java	/common-util/src/main/java/com/sun/enterprise/util	line 123	Java Problem
Varargs methods should only override or be overridden by other varargs methods unlike new ConfigCode(){}.run(ConfigBeanProxy[]) and ConfigCode.run(ConfigBeanProxy...)	PortImpl.java	/kernel/src/main/java/org/glassfish/kernel/embedded	line 73	Java Problem

Unlikely argument type for equals(): char[] seems to be unrelated to String	DSManagedConnectionFactory.java	/connectors-ra-redeploy-jars/src/main/java/com/sun/jdbcra/spi	line 607	Java Problem
Unlikely argument type for equals(): char[] seems to be unrelated to String	XAManagedConnectionFactory.java	/connectors-ra-redeploy-jars/src/main/java/com/sun/jdbcra/spi	line 563	Java Problem
## Unlikely argument type SimpleJndiName for remove(Object) on a Map<String,NamingObjectProxy>	ManagedBeanManagerImpl.java	/container-common/src/main/java/com/sun/enterprise/container/common/impl/managedbean	line 338	Java Problem
## Unlikely argument type for equals(): SimpleJndiName seems to be unrelated to String	JdbcConnPoolAppStatsProvider.java	/jdbc-runtime/src/main/java/org/glassfish/jdbc/pool/monitor	line 90	Java Problem
## Unlikely argument type for equals(): SimpleJndiName seems to be unrelated to String	JdbcConnPoolAppStatsProvider.java	/jdbc-runtime/src/main/java/org/glassfish/jdbc/pool/monitor	line 109	Java Problem
## Unlikely argument type for equals(): SimpleJndiName seems to be unrelated to String	JdbcConnPoolAppStatsProvider.java	/jdbc-runtime/src/main/java/org/glassfish/jdbc/pool/monitor	line 124	Java Problem
## Unlikely argument type for equals(): SimpleJndiName seems to be unrelated to String	JdbcConnPoolAppStatsProvider.java	/jdbc-runtime/src/main/java/org/glassfish/jdbc/pool/monitor	line 136	Java Problem

Null pointer access: The variable infos can only be null at this location	LoggingImpl.java	/amx-core/src/main/java/org/glassfish/admin/amx/impl/mbean	line 374	Java Problem

The assignment to variable description has no effect	CciIndexedRecord.java	/cciblackbox-tx/src/main/java/com/sun/connector/cciblackbox	line 61	Java Problem
The assignment to variable delimeter has no effect	DigestAlgorithmParameterImpl.java	/security-ee/src/main/java/com/sun/enterprise/security/ee/authentication/glassfish/digest/impl	line 39	Java Problem
The assignment to variable delimeter has no effect	DigestAlgorithmParameterImpl.java	/security-ee/src/main/java/com/sun/enterprise/security/ee/authentication/glassfish/digest/impl	line 52	Java Problem
@escay
Copy link
Contributor Author

escay commented Mar 26, 2024

Fix is merged into main. Closing issue.

@escay escay closed this as completed Mar 26, 2024
@dmatej dmatej added this to the 7.0.14 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants