Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s.s.s.ServerHandshaker uses Ctor not existing in current JDK #8

Closed
pzygielo opened this issue Oct 19, 2018 · 6 comments
Closed

s.s.s.ServerHandshaker uses Ctor not existing in current JDK #8

pzygielo opened this issue Oct 19, 2018 · 6 comments
Assignees

Comments

@pzygielo
Copy link

session = new SSLSessionImpl(protocolVersion, CipherSuite.C_NULL,
getLocalSupportedSignAlgs(),
sslContext.getSecureRandom(),
getHostAddressSE(), getPortSE(),
(requestedToUseEMS &&
(protocolVersion.v >= ProtocolVersion.TLS10.v)));

Please see payara/Payara#3284 for original report on this.

@smillidge
Copy link

@anajosep can you port over the change you put on the JavaEE repo javaee/grizzly-npn@4082270. This will be needed for the December Eclipse GlassFish release.

@anajosep
Copy link
Member

@smillidge Yes I will be porting this change to the Eclipse Grizzly NPN as well.

@rlfnb
Copy link

rlfnb commented Nov 9, 2018

Just out for curiosity: https://www.oracle.com/technetwork/java/faq-sun-packages-142232.html

I'm facing the problem (depending on unstable APIs) more and more often in multiple JavaEE libraries (Jersey, Grizzly...). (com)?.sun.* packages were never part of the public API. Maybe, it makes sense for future stability to get rid of all (com)?.sun.* (and other non public APIs in the JDK as well) packages?

@smillidge
Copy link

these changes are required because fundamentally the JDK 8 SSL packages do not support ALPN negotiation. ALPN support didn't come in until JDK9+. That is why this jar is required, it replaces the JDK 8 SSL classes with versions that support ALPN negotiation.

@smillidge
Copy link

@anajosep any idea when you will port as otherwise Eclipse GF will go out not working on the latest JDK 8

@anajosep
Copy link
Member

anajosep commented Dec 9, 2018

This issue is addressed by Grizzly NPN 1.9 uploaded to OSSRH staging repository.
The PR eclipse-ee4j/glassfish#22650 is merged to include it to the GlassFish bundle.
Closing this issue.

@anajosep anajosep closed this as completed Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants