KeepAliveStats doesn't register when connections are closed.

[glassfishrobot]

The result of SelectorThread.getKeepAliveStats().getCountConnections() never decreases when
connections are closed, so instead of returning the current number of open connections, it returns the
total number of connections over the full lifetime of the application.

From the implementation, it seems we are missing the logic to decrease the count:

public boolean trap(SelectionKey key){
if ( maxKeepAliveRequests == -1) return true;
Integer count = keepAliveCounts.get(key);
if ( count == null ){
count = 0;
if (keepAliveStats != null)

{ keepAliveStats.incrementCountConnections(); }

}
if ((count++) > maxKeepAliveRequests){
if (keepAliveStats != null)

{ keepAliveStats.incrementCountRefusals(); }

return false;
}
keepAliveCounts.put(key, count);
if (keepAliveStats != null)

{ keepAliveStats.incrementCountHits(); }

return true;
}
/**

• Stop monitoring keep-alive request count for the given connection.
  */
  public void untrap(SelectionKey key) { if ( maxKeepAliveRequests == -1) return; keepAliveCounts.remove(key); }

Inside the untrap(..), we must decrease the count. Can you file a bug here:

Environment

Operating System: All
Platform: All

Affected Versions

[1.9.22]

[glassfishrobot]

@glassfishrobot Commented
Reported by speck@java.net

[glassfishrobot]

@glassfishrobot Commented
Was assigned to jfarcand@java.net

[glassfishrobot]

@glassfishrobot Commented
jfarcand@java.net said:
Fixed

[glassfishrobot]

@glassfishrobot Commented
jfarcand@java.net said:
Don't know why I've added fixed in comments, but left the bug open

[glassfishrobot]

@glassfishrobot Commented
jfarcand@java.net said:
Fix milestones

[glassfishrobot]

@glassfishrobot Commented
Marked as fixed on Wednesday, December 16th 2009, 6:14:16 pm

[glassfishrobot]

@glassfishrobot Commented
This issue was imported from java.net JIRA GRIZZLY-46

[glassfishrobot]

• Issue Imported From: KeepAliveStats doesn't register when connections are closed. javaee/grizzly#46
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @glassfishrobot
• Original Issue Closed By:@glassfishrobot