Skip to content

Commit

Permalink
Migrate <managed-bean> to @nAmed -- pass1
Browse files Browse the repository at this point in the history
Noticed a bunch of ManagedPropertyBean related tests which should either
be removed or be reworked to use @ManagedProperty instead
  • Loading branch information
BalusC committed Mar 2, 2022
1 parent a241487 commit 22abd19
Show file tree
Hide file tree
Showing 96 changed files with 56 additions and 700 deletions.
1 change: 1 addition & 0 deletions src/com/sun/ts/tests/jsf/common/beans/AlbumBean.java
Expand Up @@ -26,6 +26,7 @@

import jakarta.faces.event.ActionEvent;

@jakarta.inject.Named("album") @jakarta.enterprise.context.RequestScoped
public class AlbumBean implements Serializable {

private String artist;
Expand Down
Expand Up @@ -25,6 +25,7 @@

import jakarta.faces.event.ActionEvent;

@jakarta.inject.Named("ajaxtag") @jakarta.enterprise.context.SessionScoped
public class AjaxTagValuesBean {

private Integer count = 0;
Expand Down
8 changes: 0 additions & 8 deletions src/com/sun/ts/tests/jsf/spec/ajax/common/faces-config.xml
Expand Up @@ -22,12 +22,4 @@
xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd"
version="3.0">

<managed-bean>
<managed-bean-name>ajaxtag</managed-bean-name>
<managed-bean-class>
com.sun.ts.tests.jsf.spec.ajax.common.AjaxTagValuesBean
</managed-bean-class>
<managed-bean-scope>session</managed-bean-scope>
</managed-bean>

</faces-config>
Expand Up @@ -21,11 +21,6 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd"
version="3.0">
<managed-bean>
<managed-bean-name>orderingBean</managed-bean-name>
<managed-bean-class>com.sun.ts.tests.jsf.spec.appconfigresources.common.beans.OrderingBean</managed-bean-class>
<managed-bean-scope>session</managed-bean-scope>
</managed-bean>

<name>D</name>

Expand Down
Expand Up @@ -20,6 +20,7 @@

package com.sun.ts.tests.jsf.spec.appconfigresources.common.beans;

@jakarta.inject.Named("Question") @jakarta.enterprise.context.SessionScoped
public class AnswerNoBean {

private String answer;
Expand Down
Expand Up @@ -19,6 +19,7 @@
*/
package com.sun.ts.tests.jsf.spec.appconfigresources.common.beans;

@jakarta.inject.Named("Answer") @jakarta.enterprise.context.SessionScoped
public class AnswerYesBean {

private String answer;
Expand Down
Expand Up @@ -19,6 +19,7 @@
*/
package com.sun.ts.tests.jsf.spec.appconfigresources.common.beans;

@jakarta.inject.Named("Ball") @jakarta.enterprise.context.SessionScoped
public class ColorBlueBean {

private String color;
Expand Down
Expand Up @@ -19,6 +19,7 @@
*/
package com.sun.ts.tests.jsf.spec.appconfigresources.common.beans;

@jakarta.inject.Named("Color") @jakarta.enterprise.context.SessionScoped
public class ColorRedBean {

private String color;
Expand Down
Expand Up @@ -28,6 +28,7 @@
import jakarta.faces.lifecycle.Lifecycle;
import jakarta.faces.lifecycle.LifecycleFactory;

@jakarta.inject.Named("orderingBean") @jakarta.enterprise.context.SessionScoped
public class OrderingBean {

private String[] suffixes;
Expand Down
Expand Up @@ -20,6 +20,7 @@

package com.sun.ts.tests.jsf.spec.appconfigresources.common.beans;

@jakarta.inject.Named("Status") @jakarta.enterprise.context.SessionScoped
public class StatBean {
private String testString;

Expand Down
Expand Up @@ -21,11 +21,5 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd"
version="3.0">
<managed-bean>
<managed-bean-name>orderingBean</managed-bean-name>
<managed-bean-class>com.sun.ts.tests.jsf.spec.appconfigresources.common.beans.OrderingBean</managed-bean-class>
<managed-bean-scope>session</managed-bean-scope>
</managed-bean>


</faces-config>
Expand Up @@ -21,11 +21,4 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd"
version="3.0">
<managed-bean>
<managed-bean-name>Color</managed-bean-name>
<managed-bean-class>
com.sun.ts.tests.jsf.spec.appconfigresources.common.beans.ColorRedBean
</managed-bean-class>
<managed-bean-scope>session</managed-bean-scope>
</managed-bean>
</faces-config>
Expand Up @@ -21,11 +21,4 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd"
version="3.0">
<managed-bean>
<managed-bean-name>Answer</managed-bean-name>
<managed-bean-class>
com.sun.ts.tests.jsf.spec.appconfigresources.common.beans.AnswerYesBean
</managed-bean-class>
<managed-bean-scope>session</managed-bean-scope>
</managed-bean>
</faces-config>
Expand Up @@ -21,11 +21,4 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd"
version="3.0">
<managed-bean>
<managed-bean-name>Status</managed-bean-name>
<managed-bean-class>
com.sun.ts.tests.jsf.spec.appconfigresources.common.beans.StatBean
</managed-bean-class>
<managed-bean-scope>session</managed-bean-scope>
</managed-bean>
</faces-config>
Expand Up @@ -21,11 +21,4 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd"
version="3.0">
<managed-bean>
<managed-bean-name>Ball</managed-bean-name>
<managed-bean-class>
com.sun.ts.tests.jsf.spec.appconfigresources.common.beans.ColorBlueBean
</managed-bean-class>
<managed-bean-scope>session</managed-bean-scope>
</managed-bean>
</faces-config>
Expand Up @@ -21,11 +21,4 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd"
version="3.0">
<managed-bean>
<managed-bean-name>Question</managed-bean-name>
<managed-bean-class>
com.sun.ts.tests.jsf.spec.appconfigresources.common.beans.AnswerNoBean
</managed-bean-class>
<managed-bean-scope>session</managed-bean-scope>
</managed-bean>
</faces-config>
Expand Up @@ -23,6 +23,7 @@
import jakarta.faces.event.ActionEvent;
import jakarta.faces.event.ActionListener;

@jakarta.inject.Named("beanOne") @jakarta.enterprise.context.RequestScoped
public class BeanOne implements ActionListener {

public ActionListener getTestOneEventListener() {
Expand Down
Expand Up @@ -21,11 +21,4 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd"
version="3.0">
<managed-bean>
<managed-bean-name>beanOne</managed-bean-name>
<managed-bean-class>
com.sun.ts.tests.jsf.spec.composite.actionsource.BeanOne
</managed-bean-class>
<managed-bean-scope>request</managed-bean-scope>
</managed-bean>
</faces-config>
Expand Up @@ -21,12 +21,4 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd"
version="3.0">

<managed-bean>
<managed-bean-name>album</managed-bean-name>
<managed-bean-class>
com.sun.ts.tests.jsf.common.beans.AlbumBean
</managed-bean-class>
<managed-bean-scope>request</managed-bean-scope>
</managed-bean>
</faces-config>
Expand Up @@ -24,6 +24,7 @@
import jakarta.faces.event.ValueChangeEvent;
import jakarta.faces.event.ValueChangeListener;

@jakarta.inject.Named("firstname") @jakarta.enterprise.context.SessionScoped
public class FirstNameBean implements ValueChangeListener {

public ValueChangeListener getValueChangeListener() {
Expand Down
Expand Up @@ -24,6 +24,7 @@
import jakarta.faces.event.ValueChangeEvent;
import jakarta.faces.event.ValueChangeListener;

@jakarta.inject.Named("lastname") @jakarta.enterprise.context.SessionScoped
public class LastNameBean implements ValueChangeListener {

public ValueChangeListener getValueChangeListener() {
Expand Down
Expand Up @@ -22,19 +22,4 @@
xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd"
version="3.0">

<managed-bean>
<managed-bean-name>firstname</managed-bean-name>
<managed-bean-class>
com.sun.ts.tests.jsf.spec.composite.editablevalueholder.FirstNameBean
</managed-bean-class>
<managed-bean-scope>session</managed-bean-scope>
</managed-bean>

<managed-bean>
<managed-bean-name>lastname</managed-bean-name>
<managed-bean-class>
com.sun.ts.tests.jsf.spec.composite.editablevalueholder.LastNameBean
</managed-bean-class>
<managed-bean-scope>session</managed-bean-scope>
</managed-bean>
</faces-config>
3 changes: 1 addition & 2 deletions src/com/sun/ts/tests/jsf/spec/coretags/common/BookBean.java
Expand Up @@ -19,9 +19,8 @@
import java.io.Serializable;

import jakarta.annotation.PostConstruct;
import jakarta.enterprise.context.RequestScoped;

@RequestScoped
@jakarta.inject.Named("book") @jakarta.enterprise.context.RequestScoped
public class BookBean implements Serializable {

private String authorName;
Expand Down
Expand Up @@ -24,6 +24,7 @@

import jakarta.faces.model.SelectItem;

@jakarta.inject.Named("Music") @jakarta.enterprise.context.RequestScoped
public class SelectItemsBean {

private List<String> myList;
Expand Down
Expand Up @@ -21,13 +21,4 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd"
version="3.0">

<managed-bean>
<managed-bean-name>Music</managed-bean-name>
<managed-bean-class>
com.sun.ts.tests.jsf.spec.coretags.common.SelectItemsBean
</managed-bean-class>
<managed-bean-scope>request</managed-bean-scope>
</managed-bean>

</faces-config>
Expand Up @@ -21,14 +21,6 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd"
version="3.0">

<managed-bean>
<managed-bean-name>book</managed-bean-name>
<managed-bean-class>
com.sun.ts.tests.jsf.spec.coretags.common.BookBean
</managed-bean-class>
<managed-bean-scope>request</managed-bean-scope>
</managed-bean>

<navigation-rule>
<from-view-id>/test_facelet.xhtml</from-view-id>
Expand Down
Expand Up @@ -22,6 +22,7 @@

import java.io.Serializable;

@jakarta.inject.Named("applicationScoped") @jakarta.enterprise.context.ApplicationScoped
public class ApplicationScopedBean implements Serializable {
{
this.setStringProperty("default");
Expand Down
Expand Up @@ -25,6 +25,7 @@
import jakarta.annotation.PostConstruct;
import jakarta.annotation.PreDestroy;

@jakarta.inject.Named("applicationScopedPackagePrivate") @jakarta.enterprise.context.ApplicationScoped
public class ApplicationScopedPackagePrivateBean extends ScopedBean
implements Serializable {

Expand Down
Expand Up @@ -25,6 +25,7 @@
import jakarta.annotation.PostConstruct;
import jakarta.annotation.PreDestroy;

@jakarta.inject.Named("applicationScopedPrivate") @jakarta.enterprise.context.ApplicationScoped
public class ApplicationScopedPrivateBean extends ScopedBean
implements Serializable {

Expand Down
Expand Up @@ -25,6 +25,7 @@
import jakarta.annotation.PostConstruct;
import jakarta.annotation.PreDestroy;

@jakarta.inject.Named("applicationScopedProtected") @jakarta.enterprise.context.ApplicationScoped
public class ApplicationScopedProtectedBean extends ScopedBean
implements Serializable {

Expand Down
Expand Up @@ -25,6 +25,7 @@
import jakarta.annotation.PostConstruct;
import jakarta.annotation.PreDestroy;

@jakarta.inject.Named("applicationScopedPublic") @jakarta.enterprise.context.ApplicationScoped
public class ApplicationScopedPublicBean extends ScopedBean
implements Serializable {

Expand Down
Expand Up @@ -22,6 +22,7 @@

import java.io.Serializable;

@jakarta.inject.Named("noScope")
public class NoScopeBean implements Serializable {
private String stringProperty;

Expand Down
Expand Up @@ -22,6 +22,7 @@

import java.io.Serializable;

@jakarta.inject.Named("requestScoped") @jakarta.enterprise.context.RequestScoped
public class RequestScopedBean implements Serializable {
private String stringProperty;

Expand Down
Expand Up @@ -25,6 +25,7 @@
import jakarta.annotation.PostConstruct;
import jakarta.annotation.PreDestroy;

@jakarta.inject.Named("requestScopedPackagePrivate") @jakarta.enterprise.context.RequestScoped
public class RequestScopedPackagePrivateBean extends ScopedBean
implements Serializable {

Expand Down
Expand Up @@ -25,6 +25,7 @@
import jakarta.annotation.PostConstruct;
import jakarta.annotation.PreDestroy;

@jakarta.inject.Named("requestScopedPrivate") @jakarta.enterprise.context.RequestScoped
public class RequestScopedPrivateBean extends ScopedBean
implements Serializable {

Expand Down
Expand Up @@ -25,6 +25,7 @@
import jakarta.annotation.PostConstruct;
import jakarta.annotation.PreDestroy;

@jakarta.inject.Named("requestScopedProtected") @jakarta.enterprise.context.RequestScoped
public class RequestScopedProtectedBean extends ScopedBean
implements Serializable {

Expand Down
Expand Up @@ -25,6 +25,7 @@
import jakarta.annotation.PostConstruct;
import jakarta.annotation.PreDestroy;

@jakarta.inject.Named("requestScopedPublic") @jakarta.enterprise.context.RequestScoped
public class RequestScopedPublicBean extends ScopedBean
implements Serializable {

Expand Down
Expand Up @@ -24,6 +24,7 @@

import jakarta.annotation.PostConstruct;

@jakarta.inject.Named("RuntimeExceptionPostConstruct") @jakarta.enterprise.context.RequestScoped
public class RuntimeExceptionPostConstructBean implements Serializable {

// intentionally generate an unchecked exception
Expand Down
Expand Up @@ -24,6 +24,7 @@

import jakarta.annotation.PreDestroy;

@jakarta.inject.Named("RuntimeExceptionPreDestroy") @jakarta.enterprise.context.RequestScoped
public class RuntimeExceptionPreDestroyBean implements Serializable {

// intentionally generate an unchecked exception
Expand Down
Expand Up @@ -22,6 +22,7 @@

import java.io.Serializable;

@jakarta.inject.Named("sessionScoped") @jakarta.enterprise.context.SessionScoped
public class SessionScopedBean implements Serializable {
private String stringProperty;

Expand Down
Expand Up @@ -25,6 +25,7 @@
import jakarta.annotation.PostConstruct;
import jakarta.annotation.PreDestroy;

@jakarta.inject.Named("sessionScopedPackagePrivate") @jakarta.enterprise.context.SessionScoped
public class SessionScopedPackagePrivateBean extends ScopedBean
implements Serializable {

Expand Down

0 comments on commit 22abd19

Please sign in to comment.