Skip to content

Commit

Permalink
Fixes #926 - bad StringBuffer reuse in websocket/spec/servercontainer…
Browse files Browse the repository at this point in the history
… upgradeHttpToWebSocketTest
  • Loading branch information
joakime committed Apr 13, 2022
1 parent a2ce7be commit 5aaf487
Showing 1 changed file with 13 additions and 7 deletions.
Expand Up @@ -35,11 +35,6 @@ public class WSClient extends WebSocketCommonClient {

private static final String MESSAGE_TEXT = "TCK upgrade test message";

private static StringBuffer receivedMessageString = new StringBuffer();

static CountDownLatch messageLatch;


public static void main(String[] args) {
new WSClient().run(args);
}
Expand Down Expand Up @@ -69,7 +64,12 @@ public void upgradeHttpToWebSocketTest() throws Fault {
WebSocketContainer clientContainer = ContainerProvider.getWebSocketContainer();
ClientEndpointConfig config = ClientEndpointConfig.Builder.create().build();

messageLatch = new CountDownLatch(1);
CountDownLatch messageLatch = new CountDownLatch(1);
StringBuffer receivedMessageString = new StringBuffer();

config.getUserProperties().put("messageLatch", messageLatch);
config.getUserProperties().put("receivedMessageString", receivedMessageString);

Session session = clientContainer.connectToServer(
TCKUpgradeEndpoint.class,
config, new URI("ws://" + _hostname + ":" + _port + "/" + getContextRoot() + "/TCKTestServlet"));
Expand Down Expand Up @@ -97,9 +97,15 @@ public void upgradeHttpToWebSocketTest() throws Fault {

public final static class TCKUpgradeEndpoint extends Endpoint {

private CountDownLatch messageLatch;
private StringBuffer receivedMessageString;

@Override
public void onOpen(Session session, EndpointConfig config) {


messageLatch = (CountDownLatch)config.getUserProperties().get("messageLatch");
receivedMessageString = (StringBuffer)config.getUserProperties().get("receivedMessageString");

session.addMessageHandler(new MessageHandler.Whole<String>() {

@Override
Expand Down

0 comments on commit 5aaf487

Please sign in to comment.