Update lib/schemas references (e.g. install, release, tests under src) to use either EE 9 or Jakarta EE 8 schemas (as per Jan 21, 2020 VOTE: backward compatibility for descriptor schemas). Also drop unused lib/schemas + lib/dtds #266
Comments
scottmarlow
changed the title
|
Also switch tests to Jakarta EE 9 XSDs + DTDs. EE 9 XSDs are at https://jakarta.ee/xml/ns/jakartaee/#9 (source is at https://github.com/eclipse-ee4j/jakartaee-schemas/tree/master/jakartaee9/src) Doing a search via |
|
Pushed some whitebox.jar connector XSD changes to https://github.com/scottmarlow/jakartaee-tck/tree/XSDs, looks like we have around 1915 references to http://java.sun.com/xml/ns/j2ee to examine as well. |
|
I don't see many references to /lib/schemas/*.xsd files, just the following: We can remove the other XSD files from lib/schemas and see if that causes any issues. This can be done separately I think than the src changes to use the EE9 schemas. |
|
Also need to replace |
|
Remaining references to http://xmlns.jcp.org/xml/ns/javaee: |
|
Scott is updating various application.xml references as needed: @alwin-joseph is updating persistence.xml and other files under src/com/sun/ts/tests/jpa including: References to http://java.sun.com.*xsd: |
|
Just checking , there are references to http://xmlns.jcp.org/xml/ns/javaee throughout the repo. For standalone tcks : Should those be updated too |
|
@alwin-joseph yes, although I am updating all of the application.xml files except for those you already did in tests/jpa. Please do verify that https://jakarta.ee/xml/ns/jakartaee does have a replacement though, which it should. |
As mentioned above the above count of files with DTD references in it, include vendor (e.g. GlassFish) deployment descriptors in it. IMO, we do not need to update the vendor specific deployment descriptors as vendor deployment descriptors can still contain whatever content is expected by the vendor implementation (e.g. GlassFish). So, we need to ignore the vendor specific deployment descriptors when doing a global search/replace of DTDs. |
|
Below is a list of the actual DTDs that we use in the Platform TCK (still building list as work in progress). DTDs that are referenced in TCK tests but not yet updated to EE 9 in Platform TCK: |
|
We likely can replace the mentioned DTDs based on searching for the named DTD files in previous comment. IMO, we should do a similar update for each XSD named on http://www.oracle.com/webfolder/technetwork/jsc/xml/ns/javaee/index.html#4 |
#458 covers the above
Above was corrected using Pending references to http://xmlns.jcp.org/xml/ns/javaee below :
|
|
Thanks @alwin-joseph! |
|
I updated the DTDs via #474. |
|
@alwin-joseph is anyone working on updating the "Pending references to http://xmlns.jcp.org/xml/ns/javaee" that you mentioned above in your previous comment on this issue? |
I am working on below, yet to fix the test failures caused due to replacing this with jakartaee ns.
|
|
We also still have the above mentioned |
|
What would be the replacement for http://java.sun.com/xml/ns/javaee/beans_1_0.xsd . I dont see any matching in https://jakarta.ee/xml/ns/jakartaee/. |
|
@alwin-joseph jakartaee/jakarta.ee#850 + jakartaee/cdi#440 appears to be open still. I noticed the ^ pull request https://deploy-preview-850--jakartaee.netlify.app/xml/ns/jakartaee/#9 has "beans_3_0.xsd | XML Schema for the Jakarta Contexts and Dependency Injection XML file (beans.xml)" |
Thanks got it. |
|
Updated the beans_1_0.xsd to latest https://jakarta.ee/xml/ns/jakartaee/beans_3_0.xsd in #494 src/com/sun/ts/tests/jaxrs/platform/managedbean299/beans.xml |
|
It looks like we still have web-app_2_3.dtd + other web-app_*.dtd in use by tests. We should remove them for Jakarta EE 9.1 via #569. @alwin-joseph if you notice any other remaining DTDs or XSDs that are not from Java EE 8, we should create a separate issue for those as well. |
No description provided.
The text was updated successfully, but these errors were encountered: