Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and promote Jakarta Expression Language 4.0 TCK for JakartaEE 9 release #387

Closed
scottmarlow opened this issue Jul 27, 2020 · 10 comments

Comments

@scottmarlow
Copy link
Contributor

scottmarlow commented Jul 27, 2020

  1. Complete userguide/documentation changes for Jakarta Expression Language TCK.
  2. Review the jakarta-expression-language-tck-4.0.0.zip bundle at https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/staged-900/ (or expression-language-tck-4.0.0.zip bundle at https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9/nightly) to look for any changes missed to be included in JakartaEE 9 release.
  3. Promote the bundle https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/staged-900/jakarta-expression-language-tck-4.0.0.zip to https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/promoted/ by using the job https://ci.eclipse.org/jakartaee-tck/job/promote_jakartaee9_eftl_bundles/.
  4. Remove the boolean parameter (EL_TCK) and comment out the respective wget + if condition in https://ci.eclipse.org/jakartaee-tck/job/promote_jakartaee9_eftl_bundles/configure so that the same bundle is not promoted again.
@scottmarlow scottmarlow changed the title Review and promote Expression Language 4.0 TCK for JakartaEE 9 release Review and promote Jakarta Expression Language 4.0 TCK for JakartaEE 9 release Jul 27, 2020
@scottmarlow
Copy link
Contributor Author

Pending review of #367 by @markt-asf + @edbratt

@alwin-joseph
Copy link
Contributor

1. Complete userguide/documentation changes for Jakarta Expression Language TCK.

#367 is merged.

@scottmarlow
Copy link
Contributor Author

Thanks @alwin-joseph, I asked for feedback from the el-dev community on promoting jakarta-expression-language-tck-4.0.0.zip.

@alwin-joseph
Copy link
Contributor

Thanks @alwin-joseph, I asked for feedback from the el-dev community on promoting jakarta-expression-language-tck-4.0.0.zip.

Just checking the email, I think you put annotations instead of EL and the link to the bundle has extra '_' in between.

@arjantijms
Copy link
Contributor

Thanks for all the work here @scottmarlow and others!

At a glance the TCK itself works, and the staged TCK passes with the staged 4.0.0 versions of the Expression Language Api and impl, and the latest GF snapshot here: https://ci.eclipse.org/el/job/2_expression-language-run-tck-against-staged-build

@scottmarlow
Copy link
Contributor Author

@arjantijms Could you please confirm that you done with making TCK changes and are ready to consider the TCK frozen?

CC: @alwin-joseph

@arjantijms
Copy link
Contributor

@scottmarlow I'm done making TCK changes, and I think it can be frozen.

@alwin-joseph
Copy link
Contributor

@arjantijms
Copy link
Contributor

Changed the standalone job at https://ci.eclipse.org/el/job/2_expression-language-run-tck-against-staged-build/ over to the Promoted TCK.

@scottmarlow
Copy link
Contributor Author

Closing, please reopen this issue if needed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants