Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and promote Jakarta JSONB 2.0.1 TCK for JakartaEE 9.1 release #694

Closed
4 tasks done
RohitKumarJain opened this issue Apr 1, 2021 · 5 comments
Closed
4 tasks done
Labels
9.1 9.1 release review and promote review and promote

Comments

@RohitKumarJain
Copy link
Contributor

RohitKumarJain commented Apr 1, 2021

@RohitKumarJain RohitKumarJain added 9.1 9.1 release review and promote review and promote labels Apr 1, 2021
@Verdent
Copy link
Contributor

Verdent commented Apr 14, 2021

  • In chapters 4.1 and 4.2 is not Java 11 explicitly mentioned.
    JAVA_HOME to the directory in which Java SE 8 is installed

  • In 4.1 is also incorrect example of jsonb.classes property
    For example, if you were using the Jakarta JSON Binding 2.0 RI, you would set this property to jsonb.classes=jakarta.json.bind-{TechnologyVersion}.jar.
    This is not how JSONB-API RI is called. Should this be changed for example like this?
    For example, if you were using the Jakarta JSON Binding 2.0 RI, you would set this property to jsonb.classes=yasson-{TechnologyVersion}.jar.

  • Also in case of jsonb.classes property, it is a bit misleading and not explicitly mentioned, that there should not be only path to the implementation, but also to all of its dependencies.

@Verdent
Copy link
Contributor

Verdent commented Apr 14, 2021

I was also capable to set up and pass all of the TCK tests on JDK 8 and also 11, using this user guide.

@Verdent
Copy link
Contributor

Verdent commented Apr 15, 2021

Hi @gurunrao , could you please mark 1. and also probably 2. as done please?

The PR with changes is merged but I as far as I could see, there was no release since that, so I am not sure if I should wait for that to verify the changes were successful or not :-) (That's why I am not sure about marking 2. also) Other then that, am I the one who should also do 3. and 4.?

@gurunrao
Copy link
Contributor

gurunrao commented Apr 15, 2021

Hi @gurunrao , could you please mark 1. and also probably 2. as done please?

The PR with changes is merged but I as far as I could see, there was no release since that, so I am not sure if I should wait for that to verify the changes were successful or not :-) (That's why I am not sure about marking 2. also) Other then that, I am the one who should also do 3. and 4.?

Sorry @Verdent - I have triggered the build, will take ~5 hrs to complete, then you should be able to see the changes.

@edbratt
Copy link
Contributor

edbratt commented Apr 15, 2021

Once the build is completed, this should be ready to promote. I've check items 1 and 2 from the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.1 9.1 release review and promote review and promote
Projects
None yet
Development

No branches or pull requests

4 participants