Mail samples tests should not be run for javaee_webprofile

[brideck]

Jakarta Mail is not a required component of the WebProfile specification, so the tests in samples/javamail should not be run when the javaee_webprofile keyword is specified.

The keywords should be updated to match the ones used for the javamail bucket which uses javaee_webprofile_optional instead.

[gurunrao]

@brideck - thanks for raising the issue, Please feel free to raise a PR with modification to https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/lib/harness/keyword.properties

[scottmarlow]

I agree with @gurunrao. This has likely been ignored in the past due to the samples just being an optional way to verify that a TCK installation works at all. 👍 for fixing it!

[brideck]

@scottmarlow @gurunrao I was trying to test my change locally, and it didn't seem sufficient to just update the keyword.properties file in my install. Do changes to that file require a rebuild of some sort in order to be honored in a test run?

[scottmarlow]

@brideck what change did you make to your keyword.properties?

[brideck]

@scottmarlow Linked a PR with the change. It's dead simple, but I've also had trouble in the past when tinkering with this file to get everything to work the way it feels like it should.

[scottmarlow]

I'm not sure from reading the https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/lib/util/ConfigUtil.java#L85 source that deals with loading the keyword.properties.

If you push your branch to github, myself (via https://ci.eclipse.org/jakartaee-tck/job/jakartaee-tck-scottmarlow) or @gurunrao or @alwin-joseph can build your branch for you. Once the TCK is built, then you can download it and run it.

[scottmarlow]

@brideck the TCK is building still, takes a while.

Are you specifying !javamail when running the samples?

I think it would be something like the following with your keyword.properties change:

ant -Dkeywords="\!javamail" runclient

[LanceAndersen]

They should not be run unless the properties file was updated incorrectly On Jan 13, 2022, at 2:07 PM, Scott Marlow ***@***.******@***.***>> wrote: @brideck<https://github.com/brideck> the TCK is building still, takes a while. Are you specifying !javamail when running the samples? I think it would be something like the following with your keyword.properties change: ant -Dkeywords="\!javamail" runclient — Reply to this email directly, view it on GitHub<#791 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABQPFOZOJ5L2QCDOZFX667LUV4PFXANCNFSM5KCS6FEA>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> ***@***.*** Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 ***@***.******@***.***>

[brideck]

I'm specifying javaee_web_profile in a run and expecting that the samples/javamail subset will not be run as part of that after making the updates for this issue. I would not think that I need to additionally gate on a javamail-related keyword if everything is set up correctly.

Running samples with the javaee_web_profile keyword specified currently only excludes the samples/ejb tests.

[brideck]

Thanks for the build, @scottmarlow . I tried it out and it ran the expected tests for me (just the jdbc sample), so rebuilding must incorporate the contents of keyword.properties somewhere that I'm not able to find.

[scottmarlow]

Closing as the linked pull request is merged. Please reopen if needed.