Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

October 2020 release date #534

Merged
merged 1 commit into from Oct 1, 2020
Merged

October 2020 release date #534

merged 1 commit into from Oct 1, 2020

Conversation

tomjenkinson
Copy link
Contributor

@tomjenkinson tomjenkinson commented Sep 30, 2020 •
edited

Relates to #431

@tomjenkinson tomjenkinson mentioned this pull request Sep 30, 2020
Closed
@scottmarlow
Copy link
Contributor

@tomjenkinson I asked Alwin Joseph + Ed Bratt to also review this change to remove the incorrect date. Since we cannot add a correct (future) date without breaking hugo, I think that this change is appropriate.

Please do sign the commit for this pr. I think git commit --amend --signoff should help do that. Thanks!

@tomjenkinson
Copy link
Contributor Author

Signed it - thanks for the notification!

@scottmarlow
Copy link
Contributor

@tomjenkinson we have been using Month + Year in the user guides, so to be consistent with that, could you please update to October 2020 which will be correct tomorrow. :-)

@tomjenkinson
Change to October 2020 as the release date from Jakarta Transactions …
b95d0c3 
…user guide

Signed-off-by: Tom Jenkinson <tom.jenkinson@redhat.com>
@tomjenkinson
Copy link
Contributor Author

No problem - I have put it to October 2020

@tomjenkinson tomjenkinson changed the title Remove September 2020 as the release date from Jakarta Transactions u… October 2020 release date Oct 1, 2020
@scottmarlow scottmarlow merged commit d392e93 into jakartaee:master Oct 1, 2020
@scottmarlow
Copy link
Contributor

Thanks @tomjenkinson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottmarlow scottmarlow scottmarlow approved these changes

@alwin-joseph alwin-joseph alwin-joseph approved these changes

@edbratt edbratt Awaiting requested review from edbratt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomjenkinson @scottmarlow @alwin-joseph