Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should JAXB 3.0's ModuleUtil be referring to "com.sun.xml.internal.bind.v2.ContextFactory" RI class? #172

Closed
andymc12 opened this issue Nov 19, 2020 · 2 comments
Closed

Should JAXB 3.0's ModuleUtil be referring to "com.sun.xml.internal.bind.v2.ContextFactory" RI class? #172

andymc12 opened this issue Nov 19, 2020 · 2 comments
Assignees
@andymc12

Comments

@andymc12
Copy link
Contributor

When pulling in the JAXB 3.0 implementation in Open Liberty, we ran into an issue where the ModuleUtil file still references the old com.sun.xml.internal.bind.v2.ContextFactory reference implementation (see https://github.com/eclipse-ee4j/jaxb-api/blob/b717e34080470d12dfdd2daf74c3100dddae7c2b/jaxb-api/src/main/java/jakarta/xml/bind/ModuleUtil.java#L37 ). I believe that it should be referencing org.glassfish.jaxb.runtime.v2.ContextFactory instead.

If this was an oversight in the 3.0 release, I would be happy to update the classname in ModuleUtil. In that case would it be possible to publish a 3.0.1 release that includes this change? Thanks!
@Siedlerchr
Copy link

Siedlerchr commented Dec 3, 2020 •
edited

Yes, we are facing the same error in our project and then get the error: [java.lang.ClassNotFoundException: com.sun.xml.bind.v2.ContextFactory]

We could solve our issue now.

@Siedlerchr Siedlerchr mentioned this issue Dec 3, 2020
Closed
andymc12 added a commit to andymc12/jaxb-api that referenced this issue Dec 3, 2020
@andymc12
[jakartaee#172] Update default factory class to current CI
3ca097e 
Signed-off-by: Andy McCright <j.andrew.mccright@gmail.com>
@andymc12 andymc12 mentioned this issue Dec 3, 2020
Closed
@andymc12 andymc12 self-assigned this Dec 3, 2020
@tobiasdiez tobiasdiez mentioned this issue Dec 4, 2020
Open
33 tasks
lukasj added a commit to lukasj/jaxb-api that referenced this issue Feb 19, 2021
@lukasj
jakartaee#172: default factory class name
02eee4e 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
lukasj added a commit to lukasj/jaxb-api that referenced this issue Feb 19, 2021
@lukasj
jakartaee#172: default factory class name
c5e405a 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
lukasj added a commit that referenced this issue Feb 19, 2021
@lukasj
#172: default factory class name
a0cc226 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj
Copy link
Contributor

lukasj commented Feb 19, 2021

fixed by #176

@lukasj lukasj closed this as completed Feb 19, 2021
@jhanders34 jhanders34 mentioned this issue May 21, 2021
Merged
jhanders34 added a commit to jhanders34/open-liberty that referenced this issue May 24, 2021
@jhanders34
Clean up jakarta jaxb API bundle
23ef69b 
- Update to use JAXB API 3.0.1
- Remove module-info.class from the bundle
- Stop doing override now that the fix is in the 3.0.1 API jars as fixed
with jakartaee/jaxb-api#172
- Update the API jar to be a mutli release jar since it has v9 version
of ModuleUtil

This completes
OpenLiberty@56139cc#r451592082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andymc12 andymc12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#172] Update default factory class to current CI andymc12/jaxb-api
3 participants
@Siedlerchr @lukasj @andymc12