Update EFSL for Specifications and Javadoc #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkal
requested review from
asoldano,
mkarg,
arjantijms,
spericas,
kwsutter,
m0mus,
jansupol and
andymc12
arjantijms
approved these changes
May 23, 2020
mkarg
approved these changes
May 23, 2020
|
The changes seem to follow #871. Two questions:
|
Yes, here:
Good catch. But let's create a separate pull request for this, as this isn't related to the EFSL changes. |
andymc12
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request applies the changes requested in #871.
Please note that the configuration of the javadocs plugin was broken, as it didn't include the
EFSL.html. This has been fixed as part of the PR.Please review the changes carefully. I'm not 100% sure if everything is fine this way, but the changes are essentially the same as for the EJB spec.
As these are no API changes, this is a fast-track review period of just one day as per our committer rules.