Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing spec doc v3.1 #977

Merged
merged 7 commits into from
Jul 20, 2021
Merged

Preparing spec doc v3.1 #977

merged 7 commits into from
Jul 20, 2021

Conversation

mkarg
Copy link
Contributor

@mkarg mkarg commented Jun 19, 2021

Collection of useful steps towards spec doc v3.1

As these are no API changes, this is a fast-track review period of just one day as per our committer rules.

@mkarg mkarg added this to the 3.1 milestone Jun 19, 2021
@mkarg mkarg self-assigned this Jun 19, 2021
@mkarg mkarg added this to To do in Release.next via automation Jun 19, 2021
@mkarg mkarg removed the spec label Jun 19, 2021
@andymc12
Copy link
Contributor

It looks like the CI tasks are not running for this PR and at least a few of the others too. For these PRs that upgrade build tools, I'd really like to see the CI pass to ensure that some tool upgrade doesn't have a regression that breaks us.

@mkarg
Copy link
Contributor Author

mkarg commented Jun 21, 2021

It looks like the CI tasks are not running for this PR and at least a few of the others too. For these PRs that upgrade build tools, I'd really like to see the CI pass to ensure that some tool upgrade doesn't have a regression that breaks us.

Me too. Already asked the EF admins for help.

@mkarg mkarg force-pushed the asciidoctor-versionbump branch 2 times, most recently from 9cc5a35 to 15cb992 Compare June 27, 2021 07:36
@mkarg
Copy link
Contributor Author

mkarg commented Jun 27, 2021

It looks like the CI tasks are not running for this PR and at least a few of the others too. For these PRs that upgrade build tools, I'd really like to see the CI pass to ensure that some tool upgrade doesn't have a regression that breaks us.
Me too. Already asked the EF admins for help.

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=574335. It seems the EF needs to migrate the repositories from travis.org to travis.com. I did that for my persoanl JAX-RS fork and force-pushed to this PR (BTW, all committers should do that if they want to use travis), so @andymc12 here you have an interim proof that this PR passes fine: https://travis-ci.com/github/mkarg/jaxrs-api/builds/230976115.

spericas
spericas requested changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not remove contributors as part of this type of PR.

@spericas spericas removed this from To do in Release.next Jul 7, 2021
@spericas spericas added this to In progress in Jakarta REST 3.1 Jul 7, 2021
@mkarg mkarg force-pushed the asciidoctor-versionbump branch 2 times, most recently from 27f2651 to bd5498d Compare July 8, 2021 21:12
@mkarg
Copy link
Contributor Author

mkarg commented Jul 8, 2021

@spericas Done with requested changes, please withdraw your veto.

@chkal @andymc12 PR was updated, so please cast your vote again.

andymc12
andymc12 approved these changes Jul 11, 2021
View reviewed changes
Copy link
Contributor

@andymc12 andymc12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkarg
Copy link
Contributor Author

mkarg commented Jul 11, 2021

@spericas Can I merge this or do you want more changes?

@mkarg
Copy link
Contributor Author

mkarg commented Jul 17, 2021

@spericas You did not respond for another week and all your requested changes are done since ten days, so I am confused what's up. Please respond ASAP.

@spericas
Copy link
Contributor

@spericas You did not respond for another week and all your requested changes are done since ten days, so I am confused what's up. Please respond ASAP.

Sorry, was out on vacation. Will update now.

@mkarg mkarg merged commit dc042e5 into jakartaee:master Jul 20, 2021
@mkarg mkarg moved this from In progress to Done in Jakarta REST 3.1 Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chkal chkal chkal approved these changes

@spericas spericas spericas approved these changes

@andymc12 andymc12 andymc12 approved these changes

Assignees

@mkarg mkarg

Labels
project
Projects
Jakarta REST 3.1
Done
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkarg @andymc12 @spericas @chkal